<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109610/">http://git.reviewboard.kde.org/r/109610/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 20th, 2013, 11:52 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Besides the technical details, I think it's interesting to have the splash screen in QML, I wonder if there's much time to get it to load, but well I guess it's fine.
Graphically, I don't really have much taste, so I asked a friend whose taste I trust and he liked it :D. I'm unsure if that's helpful.
The only thing I can say is that maybe the colors don't really match the ones we usually use in KDevelop (i.e. the website and the welcome page). But well, I think that we can try it at least and figure out if we want a QML splash screen and maybe change it for another one before releasing.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I actually QTimer'd it, it takes about 5-10ms per redraw (and redraws only happen at each manual update call), so not too bad. I didn't check how long loading the declarative stuff takes, but we do load that anyways for the welcome page (or is that not shared?).
For the colors I'm not sure either, maybe shifting the green to the sides would help, then it would be more green overall... if you like, you can play around with it.
I will also do some fine tuning on it when it is submitted, I just wanted to see if people like the idea before investing too much work. I'll go fix the other patch and then I think I'll push it, and continue improving it "in public" ;)</pre>
<br />
<p>- Sven</p>
<br />
<p>On March 20th, 2013, 8:44 p.m. UTC, Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated March 20, 2013, 8:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is my suggestion for a new splash screen in kdevelop. Sure, application startup is short anyways, but we've had the current splash screen for ages and it's time for something new. ;)
Click here for what it looks like: http://files.feorar.org/splash.gif
Be careful, it's 3.5MB gif.
It needs a patch to kdevplatform for the progress info, which I'll submit shortly (it works without too, but you'll only see grey squares).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I verified that even if something goes wrong in QML there's no crashes or strange behavior. You'll just get the splash screen without the colorful squares. Thus I think the risk of breaking something with this is low.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>pics/misc/kdevelop-splash.xcf <span style="color: grey">(fdd2b40cbe7c6096f77519f1706cec3846a29696)</span></li>
<li>pics/misc/kdevelop-splash.png <span style="color: grey">(cf161cb634c6c3f24b743706294078eb3ed16d94)</span></li>
<li>app/splash.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/splash.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/splash.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/main.cpp <span style="color: grey">(4ad8f05)</span></li>
<li>app/CMakeLists.txt <span style="color: grey">(c0e10ed)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109610/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>