<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109529/">http://git.reviewboard.kde.org/r/109529/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Aleix Pol Gonzalez.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated March 18, 2013, 12:03 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">GitPlugin: Fix branch name in detached HEAD state
In case of detached HEAD, 'git symbolic-ref HEAD' will error out.
Instead, use 'git rev-parse' to retrieve the current branch, will output
"HEAD" in case of detached HEAD state.
Make clear that IBranchingVersionControl::currentBranch() will return an
empty string in case we're in detached state.
Add tests.
Also see: http://stackoverflow.com/a/11958481
REVIEW: 109529</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/git/gitplugin.cpp <span style="color: grey">(e2f9f1980c8a006128ce6ecce4e88f1f9964d715)</span></li>
<li>plugins/git/tests/initTest.cpp <span style="color: grey">(c55264f3c6857b8ab73cfcdd241ac5224b897870)</span></li>
<li>plugins/projectmanagerview/vcsoverlayproxymodel.cpp <span style="color: grey">(81ad8dc7922c9e22d18317173ed76dc3b526164f)</span></li>
<li>vcs/interfaces/ibranchingversioncontrol.h <span style="color: grey">(04f80e4184daf64076c6b6882a28d13b18895b9d)</span></li>
<li>vcs/models/projectchangesmodel.cpp <span style="color: grey">(4d168cac30bae076640c51cfe5da53102fbd3ad4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109529/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>