<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109532/">http://git.reviewboard.kde.org/r/109532/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 2b1e2d624c25e7988f963e3ced8ab057d232d853 by Kevin Funk to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 16th, 2013, 11:35 p.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Aleix Pol Gonzalez.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated March 16, 2013, 11:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Consists of multiple commits:
BranchesListModel: Fix UI bug
BranchesListModel::setData never called the base-class implementation,
hence setIcon() and setData() for roles != Qt::EditRole never had an
effect.
Prettify Branch Manager dialog
Changes:
* Double click now checks out the branch instead of starting a rename
* Add extra button for the rename action
* Add icons to the buttons
* Set window title
GitPlugin: Hide '(no branch)' in branch list
Do not crash in BranchManager when detached</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/git/gitplugin.cpp <span style="color: grey">(e2f9f1980c8a006128ce6ecce4e88f1f9964d715)</span></li>
<li>vcs/dvcs/ui/branchmanager.h <span style="color: grey">(62e3926bc4db9e8e422d5b38cbf418fc1f1b47d5)</span></li>
<li>vcs/dvcs/ui/branchmanager.cpp <span style="color: grey">(a19fd473a71efcd5faf2d2755f6397d0d0e8857f)</span></li>
<li>vcs/dvcs/ui/branchmanager.ui <span style="color: grey">(db8ebc422856a6a5c5ef375b98e1bc2e40e1a070)</span></li>
<li>vcs/models/brancheslistmodel.cpp <span style="color: grey">(33b089ec4b3d430daec8b22053e2cf55ba64a17f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109532/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/03/16/kdevelop_branches_new.png">Screenshot of new Branch Manager dialog</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>