<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109496/">http://git.reviewboard.kde.org/r/109496/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you please write a meaningful commit message for the fix? For instance, the root cause of the issue should be mentioned, and not just the "Fix foo" so that an average commit reader can understand without investigation much about the code change. Thank you.</pre>
<br />
<p>- Laszlo</p>
<br />
<p>On March 15th, 2013, 2:38 p.m. UTC, Florian Eßer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop, kdewin and Niko Sams.</div>
<div>By Florian Eßer.</div>
<p style="color: grey;"><i>Updated March 15, 2013, 2:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">some CMake hacks to make "emerge kdev-php" work with mingw64 / Windows 7</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"emerge kdev-php" finished successfully.
I now have PHP support in KDevelop on my Windows machine :-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>completion/CMakeLists.txt <span style="color: grey">(c38490d)</span></li>
<li>completion/tests/CMakeLists.txt <span style="color: grey">(5ba0c48)</span></li>
<li>duchain/CMakeLists.txt <span style="color: grey">(241fd69)</span></li>
<li>duchain/tests/CMakeLists.txt <span style="color: grey">(8fb3f94)</span></li>
<li>parser/CMakeLists.txt <span style="color: grey">(f66bf09)</span></li>
<li>parser/test/CMakeLists.txt <span style="color: grey">(f9307b8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109496/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>