<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109317/">http://git.reviewboard.kde.org/r/109317/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 6th, 2013, 10:59 p.m. UTC, <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Alas, I don't think this is a proper fix for the bug. The same thing can happen with actual remote projects. We should simply do a synchronization "every once in a while" or maybe even whenever the apply button is clicked in the project config dialog (or something else in the kconfig-object is saved).
I also don't like treating local files differently to remote ones here, KIO makes this all completely transparent and thats a good thing and all other places
I don't have strong objections though, so if it fixes an annoying bug and you can move the above object-creation I think it can go in.</pre>
</blockquote>
<p>On March 7th, 2013, 12:04 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">TBH I don't love it either. I agree that KIO should make it transparent, although I think that for this to happen KConfig should be the one using KIO, and not ourselves.
I think the bug is annoying enough (I'm sure all of us have hit it at some point) to try to put a solution.
An alternative I can think of, is adding a IProject::syncDeveloperConfig that calls sync and syncs the files. I'd be ok with that too, even though it adds a very specific API which is not nice either.</pre>
</blockquote>
<p>On March 7th, 2013, 7:57 a.m. UTC, <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, that requires touching several places, in particular the cmake plugin which writes to the config without going through the project-config-ui. I dislike that more than having local-files special-cased, so as I said just fix the statJob assignment and I'm fine with it.
In the end, I think exposing the KConfig object as public API might have been a bad idea, maybe we should've just exposed some set and get API taking a list-of-groups, a key name and a value. That would give the shell code full control over when syncing is necessary and it could be done in a central place...</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, KConfig eases the integration with KCM's, I think it's ok.
I'm unsure though, if we should care about too much ::sync() calls and SSD devices...
Right now we have far too much sync's in the cmake code, at least.</pre>
<br />
<p>- Aleix</p>
<br />
<p>On March 6th, 2013, 7:30 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Andreas Pakulat.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated March 6, 2013, 7:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See the bug attached.
It's of no use that we keep sync'ing the config files if they have to be moved around in the end.
What this patch does, is to not have a developerTempFile and instead use the actual developer config file (the .kdev4/*.kdev4) to read/write configurations, in case it's a local project.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Restarted some kdevelop cmake projects and it seemed to work.
Also tests didn't stop working, although it seems unlikely that anything depends on that.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=291983">291983</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/project.cpp <span style="color: grey">(b0fb221)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109317/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>