<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108814/">http://git.reviewboard.kde.org/r/108814/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit c34ad25cdb39afc1df4e5f45d0551dbf2d199b63 by Aleix Pol on behalf of Ben Wagner to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On February 7th, 2013, 11:34 p.m. UTC, Ben Wagner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Ben Wagner.</div>
<p style="color: grey;"><i>Updated Feb. 7, 2013, 11:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add SOURCES to add_custom_target. For some time now (at least since 2.6), add_custom_target has a SOURCES section with the documentation at http://www.cmake.org/cmake/help/cmake2.6docs.html#command:add_custom_target stating "The SOURCES option specifies additional source files to be included in the custom target. Specified source files will be added to IDE project files for convenience in editing even if they have not build rules." Support for this seems to be missing, this patch adds it.
Note that I cannot commit this myself, so someone else will need to push these patches.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built, run, observed change.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectmanagers/cmake/parser/cmakeast.h <span style="color: grey">(9f89c87)</span></li>
<li>projectmanagers/cmake/parser/cmakeast.cpp <span style="color: grey">(74bfd04)</span></li>
<li>projectmanagers/cmake/parser/cmakeprojectvisitor.cpp <span style="color: grey">(547adc1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108814/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/02/06/0001-Add-SOURCES-to-add_custom_target.patch">git format-patch</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/02/07/0002-Add-test-for-add_custom_target-SOURCES.patch">test</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>