<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106236/">http://git.reviewboard.kde.org/r/106236/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 7th, 2013, 9:29 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see this has a ship it but marked as uncommited. Was it commited and you forgot to close the request or is still uncommited?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still uncomitted as far as I know.</pre>
<br />
<p>- Andreas</p>
<br />
<p>On August 27th, 2012, 7:13 p.m. UTC, Nicolas Alvarez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Andreas Pakulat.</div>
<div>By Nicolas Alvarez.</div>
<p style="color: grey;"><i>Updated Aug. 27, 2012, 7:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Avoid error if the first argument to the build command contains an equals sign.
splitArgs with AbortOnMeta will return a FoundMeta error if the first word contains an equals sign, because it thinks it's a shell variable assignment, as in "LANG=C make" or similar. We were passing the list of arguments of the build command to KShell::splitArgs, without including the command itself. Thus, if the first argument (*after* the command name!) had an equals sign, like in command="make" arguments="V=1", KDevelop was saying "the given arguments would need a real shell", which isn't true.
This patch fixes the problem by passing the command name to splitArgs too (and then removing the command name from the returned split list).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I didn't even test if it compiles. I just wanted to post the patch and run to class :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectmanagers/custom-buildsystem/custombuildjob.cpp <span style="color: grey">(83af2561c149fb8c807c8c4d58371f0b727e18f5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106236/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>