<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108688/">http://git.reviewboard.kde.org/r/108688/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit ecc66015b240f3c2775b904310cbecd3c60a793f by Kevin Funk to branch 1.5.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 31st, 2013, 7:35 p.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Jan. 31, 2013, 7:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix crash in OutputModel::flushLineBuffer()
In case we try to call beginInsertRows() with invalid indices we will
trigger an assert in qabstractitemmodel.cpp.
Backtrace (reduced):
5 0x00007ffff5a7caac in qt_assert (assertion=0x7ffff5ccce63 "last >=
first", file=0x7ffff5cccbe0
"/home/krf/devel/src/qt/src/corelib/kernel/qabstractitemmodel.cpp",
line=2413) at /home/krf/devel/src/qt/src/corelib/global/qglobal.cpp:2018
6 0x00007ffff5bba5d6 in QAbstractItemModel::beginInsertRows
(this=0x72226b0, parent=..., first=35, last=34) at
/home/krf/devel/src/qt/src/corelib/kernel/qabstractitemmodel.cpp:2413
7 0x00007fffec45136f in KDevelop::OutputModel::flushLineBuffer
(this=0x72226b0) at
/home/krf/devel/src/kdevplatform/outputview/outputmodel.cpp:284
8 0x00007fffc079c6fa in CTestRunJob::processFinished (this=0x703a240,
job=0x7212ce0) at
/home/krf/devel/src/kdevelop/projectmanagers/cmake/testing/ctestrunjob.cpp:140
(gdb) p d->m_lineBuffer.size()
$1 = 0</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>outputview/outputmodel.cpp <span style="color: grey">(c4dd9c9d057aa2de92fb25ee6929acc16ef6e7af)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108688/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>