<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108694/">http://git.reviewboard.kde.org/r/108694/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 4a6ef34052cc76d0677e30f33a85ede5c6a009e9 by Kevin Funk to branch 1.5.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 31st, 2013, 11:42 p.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Jan. 31, 2013, 11:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix another crash-on-exit
Easily reproducable:
* Load project, wait for it to load
* Change CMakeLists.txt, do not save
* Build project
* Immediately close KDevelop
Backtrace (reduced):
5 0x00007f5f092b7345 in KDevelop::ProjectBaseItem::appendRow
(this=0x2425560, item=0x67255a0) at
/home/krf/devel/src/kdevplatform/project/projectmodel.cpp:421
6 0x00007f5f0ec4dad2 in KDevelop::ProjectPrivate::reloadDone
(this=0x5f0d2b0) at
/home/krf/devel/src/kdevplatform/shell/project.cpp:160
The hunk in void Project::close() fixes a consecutive crash:
#10 0x00007f72feb6faac in qt_assert (assertion=0x7f72faba5538 "row >= 0 && row < d->children.size()", file=0x7f72faba52d0 "/home/krf/devel/src/kdevplatform/project/projectmodel.cpp", line=199) at /home/krf/devel/src/qt/src/corelib/global/qglobal.cpp:2018
#11 0x00007f72fab8e4b4 in KDevelop::ProjectBaseItem::takeRow (this=0x25ed8c0, row=-1) at /home/krf/devel/src/kdevplatform/project/projectmodel.cpp:199
#12 0x00007f72fab8e9c9 in KDevelop::ProjectBaseItem::removeRow (this=<optimized out>, row=<optimized out>) at /home/krf/devel/src/kdevplatform/project/projectmodel.cpp:222
#13 0x00007f7300522b28 in KDevelop::Project::close (this=0x4dced40) at /home/krf/devel/src/kdevplatform/shell/project.cpp:555
#14 0x00007f730051c6a4 in KDevelop::ProjectController::closeProject (this=0x25ee860, proj_=<optimized out>) at /home/krf/devel/src/kdevplatform/shell/projectcontroller.cpp:869</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>project/builderjob.h <span style="color: grey">(4acbdef8e19728fd762928bc5a41b852c4468436)</span></li>
<li>project/builderjob.cpp <span style="color: grey">(24f128d02c2da2242a0539622c2e8de95a1dc30f)</span></li>
<li>shell/project.h <span style="color: grey">(eb56db521697330e3e05bd39884790789f469138)</span></li>
<li>shell/project.cpp <span style="color: grey">(a145604a818437d13572f64847781640392364d8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108694/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>