<div class="gmail_quote">2013/1/12 Morten Volden <span dir="ltr"><<a href="mailto:mvolden2@gmail.com" target="_blank">mvolden2@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="gmail_quote"><div><div>2013/1/12 Milian Wolff <span dir="ltr"><<a href="mailto:mail@milianw.de" target="_blank">mail@milianw.de</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div>On Saturday 12 January 2013 21:48:51 Milian Wolff wrote:<br>
> On Saturday 12 January 2013 20:52:02 Morten Volden wrote:<br>
> > 2013/1/12 Milian Wolff <<a href="mailto:mail@milianw.de" target="_blank">mail@milianw.de</a>><br>
> ><br>
> > > On Friday 11 January 2013 20:30:16 Morten Volden wrote:<br>
> > > > fredag den 11. januar 2013 skrev Milian Wolff :<br>
> > > > > On Friday 11 January 2013 17:48:55 Milian Wolff wrote:<br>
> > > > > > On Tuesday 18 December 2012 20:43:03 Milian Wolff wrote:<br>
> > > > > > > Hey all,<br>
> > > > > > ><br>
> > > > > > > I think we should branch off 4.5 and emplace a soft feature<br>
> > > > > > > freeze<br>
> > ><br>
> > > -<br>
> > ><br>
> > > > > > > anyone<br>
> > > > > > > against that?<br>
> > > > > ><br>
> > > > > > I'll now start creating 4.5 branches. The 4.5 branches are then<br>
> > > > ><br>
> > > > > considered<br>
> > > > ><br>
> > > > > > feature frozen!<br>
> > > > ><br>
> > > > > Done now. Any quasi-maintained plugins that I missed?<br>
> > > ><br>
> > > > Hi milian<br>
> > > ><br>
> > > > How about the Perforce-plugin? I have added you as a project manager.<br>
> > ><br>
> > > Is it stable, do you want to take maintainership? Do want it to be<br>
> > > released?<br>
> > > If so, it should move to kdereview and then merged into KDevplatform.<br>
> > ><br>
> > > Me and and about 10 other guys use it regularly at work - so I believe<br>
> > > it<br>
> ><br>
> > is stable.<br>
> ><br>
> > At my own (relatively) slow pace- Yes, I am committed to fix problems and<br>
> > feature requests :-)<br>
> ><br>
> > Yes, I would like it to be released. I just never got round to do it<br>
> > because I have no idea what is needed to do so.<br>
> ><br>
> > Would it be OK to release it separately first, and then move it into<br>
> > KDevplatform at a later stage?<br>
><br>
> Yes, but you'll have to go through KDE review first no matter what.<br>
<br>
</div></div>BTW could it be that your unit test is failling?<br>
<br>
FAIL! : PerforcePluginTest::testAdd() 'j->exec()' returned FALSE. ()<br>
Loc: [/home/milian/projects/kde4/kdev-<br>
perforce/test/perforceplugintest.cpp(136)]<br>
<br>
Generally, doesn't look like you got many tests (which is bad).<br>
<div><div><br></div></div></blockquote></div></div><div>I know (and you are right)<br><br>I'll see if I can do something about that tomorrow, and start up a review process also. <br><br></div></div></blockquote><div>
Just to let you know, I'm still working on this....(Whenever I can find the time to do it.... :-) )<br><br>I think the best way to go here is to create a stub executable of the p4 client and call that during test. There is no sense in writing a unittetst that can only be performed on my machine. <br>
<br>Cheers<br><br>/Morten<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_quote"><div>Cheers<span><font color="#888888"><br>
<br>/Morten<br>
<br> </font></span></div><div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
Cheers<br>
--<br>
Milian Wolff<br>
<a href="mailto:mail@milianw.de" target="_blank">mail@milianw.de</a><br>
<a href="http://milianw.de" target="_blank">http://milianw.de</a></div></div></blockquote></div></div><br><br clear="all"><div><div><br>-- <br>- When the split is pulled, mr. Grenade is no longer our friend
</div></div></blockquote></div><br><br clear="all"><br>-- <br>- When the split is pulled, mr. Grenade is no longer our friend