<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108492/">http://git.reviewboard.kde.org/r/108492/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure about most casing changes in Tool tips - is there a HIG or so that specifies this?</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108492/diff/1/?file=108042#file108042line69" style="color: black; font-weight: bold; text-decoration: underline;">plugins/documentview/kdevdocumentview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KDevDocumentView::KDevDocumentView( KDevDocumentViewPlugin *plugin, QWidget *parent )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">69</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setWhatsThis</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"Document <span class="hl">V</span>iew"</span> <span class="p">)</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">69</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setWhatsThis</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"Document <span class="hl">v</span>iew"</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is not a proper whats this - either remove it or extend it please</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108492/diff/1/?file=108043#file108043line61" style="color: black; font-weight: bold; text-decoration: underline;">plugins/filemanager/filemanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">61</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setWhatsThis</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"Filesystem <span class="hl">B</span>rowser"</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">61</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setWhatsThis</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"Filesystem <span class="hl">b</span>rowser"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">same here</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108492/diff/1/?file=108046#file108046line97" style="color: black; font-weight: bold; text-decoration: underline;">plugins/konsole/kdevkonsoleview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KDevKonsoleView::KDevKonsoleView( KDevKonsoleViewPlugin *plugin, QWidget* parent )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">97</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setWhatsThis</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"<b>Konsole</b><p>"</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">97</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setWhatsThis</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"This window contains an embedded console."</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">same here</pre>
</div>
<br />
<p>- Milian</p>
<br />
<p>On January 19th, 2013, 6:35 p.m. UTC, Andrea Scarpino wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Andrea Scarpino.</div>
<p style="color: grey;"><i>Updated Jan. 19, 2013, 6:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried to make consistent the tooltips as described in BUG#299317.
Also I found that sometime a bold text is used in the WhatsThis help. Looking at the others KDE applications (read KWrite, KMail,...) this bold text isn't used. So I guess that it shouldn't be used.
I also removed some <p> tag, as it seems that does nothing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kdevplatform builds.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=299317">299317</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debugger/breakpoint/breakpointwidget.cpp <span style="color: grey">(650fdf8)</span></li>
<li>debugger/framestack/framestackwidget.cpp <span style="color: grey">(f4ded95)</span></li>
<li>debugger/variable/variablewidget.cpp <span style="color: grey">(124a42e)</span></li>
<li>plugins/appwizard/appwizardplugin.cpp <span style="color: grey">(ec17a5b)</span></li>
<li>plugins/codeutils/codeutilsplugin.cpp <span style="color: grey">(fb791cc)</span></li>
<li>plugins/documentswitcher/documentswitcherplugin.cpp <span style="color: grey">(d457a5a)</span></li>
<li>plugins/documentview/kdevdocumentview.cpp <span style="color: grey">(e5c74c9)</span></li>
<li>plugins/filemanager/filemanager.cpp <span style="color: grey">(e797974)</span></li>
<li>plugins/filetemplates/filetemplatesplugin.cpp <span style="color: grey">(6ab8ab9)</span></li>
<li>plugins/grepview/grepviewplugin.cpp <span style="color: grey">(a117d59)</span></li>
<li>plugins/konsole/kdevkonsoleview.cpp <span style="color: grey">(6351a39)</span></li>
<li>shell/debugcontroller.cpp <span style="color: grey">(97e08fd)</span></li>
<li>shell/documentcontroller.cpp <span style="color: grey">(73f849e)</span></li>
<li>shell/mainwindow_p.cpp <span style="color: grey">(2b72b45)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(aba9156)</span></li>
<li>shell/runcontroller.cpp <span style="color: grey">(f603182)</span></li>
<li>shell/sessioncontroller.cpp <span style="color: grey">(936afa5)</span></li>
<li>shell/sourceformattercontroller.cpp <span style="color: grey">(8008b12)</span></li>
<li>util/environmentconfigurebutton.cpp <span style="color: grey">(8303c70)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108492/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>