<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108146/">http://git.reviewboard.kde.org/r/108146/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I had to revert this commit since it broke the build and needs a different solution. The removeHtmlFromString function cannot be in another library and be used from interfaces since that one can only link against KDE/Qt and other third-party libs not against any kdevplatform libs. So either the code using removeHtmlFromString needs to be moved out of iassistant.cpp or the function needs to be moved into the interfaces library and be used from there. No idea whats cleaner from an API pov.</pre>
<br />
<p>- Andreas</p>
<br />
<p>On January 4th, 2013, 5:48 p.m., Ivan Shapovalov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Ivan Shapovalov.</div>
<p style="color: grey;"><i>Updated Jan. 4, 2013, 5:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix HTML -> plaintext conversion when converting assistants to KAction/QMenu. This fixes at least one visible case - invoking context menu on a problem with missing declaration assistant.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Apparently works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/iassistant.cpp <span style="color: grey">(8d433a3)</span></li>
<li>plugins/problemreporter/problemreporterplugin.cpp <span style="color: grey">(27e41ee)</span></li>
<li>util/formattinghelpers.h <span style="color: grey">(d82d421)</span></li>
<li>util/formattinghelpers.cpp <span style="color: grey">(b646068)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108146/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>