<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108210/">http://git.reviewboard.kde.org/r/108210/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Personally I find this number completely useless. Why would anyone want to know how many files are shown? I'd rather want to see how many are hidden and then you wouldn't have this problem.
Apart from that I don't think sacrificing the performance in such a drastic way is worth it, especially not when people still haveproblems loading the kernel sources due to the projectsize.</pre>
<br />
<p>- Andreas</p>
<br />
<p>On January 5th, 2013, 8:59 p.m., Ivan Shapovalov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Ivan Shapovalov.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2013, 8:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When a project model filter is enabled, the ProjectProxyModel alters folder names to show count of items that match the filter.
Currently, these counts also include non-matched folders, because folders are not subject to filtering and the counts are calculated using rowCount(), so they are effectively pointless for tasks of evaluating how many matched files reside in some folder.
This patch makes these counts "real" by walking the model once again and counting actual files under the given folder. Unfortunately this changes complexity of model rendering to O(n^2)...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Existing unit-tests and manual testing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>project/projectproxymodel.h <span style="color: grey">(279389b)</span></li>
<li>project/projectproxymodel.cpp <span style="color: grey">(5da4f6c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108210/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>