<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108024/">http://git.reviewboard.kde.org/r/108024/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 30th, 2012, 4:31 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">in the "broken" case I can still jump to the error in line 14, no? i.e. the properly highlighted line is still clickable, no?
if so - then this is a good improvement and you can go for it.
thanks!</pre>
</blockquote>
<p>On December 30th, 2012, 5:06 p.m., <b>Morten Volden</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unfortunately it is not possible to jump to the highlighted line in the broken case. The CMakeLists.txt file is located under:
/home/mvo/projects/testConfigure/, but the urlForFile function will in that case only look under the current build dir (/home/mvo/projects/testConfigure/build/).
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You could special-case the cmake case then and also look in the source folder?</pre>
<br />
<p>- Milian</p>
<br />
<p>On December 30th, 2012, 3:26 p.m., Morten Volden wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Morten Volden.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2012, 3:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fixes Bug 291011 (Clicking on a configuration error in the Build toolview does not bring you to the line in the CMakeLists.txt file).
One thing tough: It seems that cmake is not consistent with regard to the order of printing out lines (for example, see the screen shots below). This means that in the (rare?) cases where the error is the first thing printed, it is not possible to jump to the error. This is because there has been no action item first telling the filtering strategy in what directory to look.
Input on how to deal with this scenario is most welcome.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added a few cmake configure test cases to filteringstrategytest.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=291011">291011</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>outputview/outputfilteringstrategies.cpp <span style="color: grey">(cccc026)</span></li>
<li>outputview/tests/filteringstrategytest.cpp <span style="color: grey">(bcd5b78)</span></li>
<li>outputview/tests/testlinebuilderfunctions.h <span style="color: grey">(3d264f7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108024/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/108024/s/941/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/30/cmake_configure_filtering_went_well_cropped_400x100.png" style="border: 1px black solid;" alt="Filtering went well" /></a>
<a href="http://git.reviewboard.kde.org/r/108024/s/942/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/30/screenshot_filteringFailed_400x100.png" style="border: 1px black solid;" alt="Not possible to jump to error" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>