<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107542/">http://git.reviewboard.kde.org/r/107542/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Milian</p>
<br />
<p>On December 1st, 2012, 3 p.m., Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Milian Wolff.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Dec. 1, 2012, 3 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">CMake: Do not create file items with unclean path
Fixes a crash later in the pipe in backgroundparser.cpp:
Original backtrace (trimmed):
5 0x00007ffff5aa41a8 in qt_assert (assertion=0x7ffff160961b
"isValidURL(url)", file=0x7ffff1609758
"/home/krf/devel/src/kdevplatform/language/backgroundparser/backgroundparser.cpp",
line=524)
6 0x00007ffff14c9ac4 in KDevelop::BackgroundParser::addDocument
(this=0xb93700, url=...,
features=KDevelop::TopDUContext::VisibleDeclarationsAndContexts,
priority=100000, notifyWhenReady=0x4c92fb0, flags=...) at
/home/krf/devel/src/kdevplatform/language/backgroundparser/backgroundparser.cpp:524
7 0x00007ffff14d95d2 in KDevelop::ParseProjectJob::start
(this=0x4c92fb0) at
/home/krf/devel/src/kdevplatform/language/backgroundparser/parseprojectjob.cpp:90
8 0x00007ffff744a84d in KDevelop::RunController::registerJob
(this=0xb936d0, job=0x4c92fb0) at
/home/krf/devel/src/kdevplatform/shell/runcontroller.cpp:566 #9
0x00007ffff7428122 in
KDevelop::ProjectController::projectImportingFinished (this=<optimized
out>, project=0x301d7a0) at
/home/krf/devel/src/kdevplatform/shell/projectcontroller.cpp:779 #10
0x00007ffff743089c in KDevelop::ProjectPrivate::importDone
(this=0x4126530, job=<optimized out>) at
/home/krf/devel/src/kdevplatform/shell/project.cpp:257 #11
0x00007ffff7430291 in KDevelop::Project::qt_static_metacall
(_o=0x301d7a0, _c=<optimized out>, _id=<optimized out>,
_a=0x7fffffffc9b0) at
/home/krf/devel/build/kdevplatform/shell/moc_project.cpp:94
BUG: 310524</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectmanagers/cmake/cmakemanager.cpp <span style="color: grey">(bbde8b7eb86f94e8a05874c2862f8fd104ba2778)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107542/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>