<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107489/">http://git.reviewboard.kde.org/r/107489/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Olivier Jean de Gaalon.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch provides a framework to allow creating json tests for arbitrary objects.
In particular, this allows declarations to be tested using a simple DUChainVisitor (also included) which extracts json data from the declaration's comments and runs the tests specified therein.
This can be used for any language (see kdevelop patch for cpp's implementation).
Please pay special attention to cmake stuff when reviewing because I have no idea what I'm doing.
Why not C++11?
> We don't support it in KDevelop yet.
Why not Boost?
> NIH
Why do the json test functions need to be included instead of linked in?
> Because you'll add your own tests, which will be added to a different instantiation of TestSuite than the provided ones because they come from another library. C++11 might help here with the export keyword, but it's not really important.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Who tests the testers?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/CMakeLists.txt <span style="color: grey">(4a306a4)</span></li>
<li>tests/json/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/json/declarationvalidator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/json/declarationvalidator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/json/delayedoutput.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/json/delayedoutput.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/json/jsondeclarationtests.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/json/jsonducontexttests.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/json/jsontesthelpers.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/json/jsontypetests.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/json/testsuite.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107489/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>