<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107296/">http://git.reviewboard.kde.org/r/107296/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit cb01708424c1b21077761c6259e50fec1fac071f by Sven Brauch to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 15th, 2012, 9:43 p.m., Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop, KDE Usability and Milian Wolff.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated Nov. 15, 2012, 9:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">TL;DR: Look at the screenshots below. :)
Make the uses widget nicer.
Main changes include:
* Fix contexts not being clickable (they were clickable but didn't work)
* Remove the blue arrows; all widgets are expanded by default and can
be collapsed with a small link in the text instead. This operation is
not common enough to justify such a huge ugly button.
(The main problem with the button was that it looked ugly, tough)
* Contexts without actual uses are always sorted last.
* Add some nice icons to the list.
* Remove all the ugly frames.
* Make text displaying code use a fixed-width font.
* Make the tooltip use a fixed-width font too, make it smaller (just 2
lines of context instead of 3), and highlight the line with the use
by making it bold-face.
* Re-format and rename all the widget headers to be more readable
and look nicer.
I will add a few comments to the patch to explain what I was doing.
Oh and also, I had that impression for quite a while now, but right now I'm pretty sure the find uses feature is broken in some way. Just look at the screenshots: it found way more occurences in the first screenshot than in the second (which happened after a reparse of some projects). And this has nothing to do with my changes. :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual testing; no functional changes were done except for the context link fix.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/duchain/navigation/useswidget.h <span style="color: grey">(ec0440e)</span></li>
<li>language/duchain/navigation/useswidget.cpp <span style="color: grey">(8c01e7c)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(6168066)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107296/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107296/s/821/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/12/useswidgetcomp_400x100.png" style="border: 1px black solid;" alt="Comparsion between the old and the new uses widget." /></a>
<a href="http://git.reviewboard.kde.org/r/107296/s/822/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/12/useswidget_new4_400x100.png" style="border: 1px black solid;" alt="The new useswidget after the latest updates" /></a>
<a href="http://git.reviewboard.kde.org/r/107296/s/832/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/14/useswidget_400x100.png" style="border: 1px black solid;" alt="Third version; the header line updates while uses are being searched" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>