<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107310/">http://git.reviewboard.kde.org/r/107310/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 13th, 2012, 4:15 p.m., <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107310/diff/1/?file=94714#file94714line96" style="color: black; font-weight: bold; text-decoration: underline;">plugins/switchtobuddy/switchtobuddyplugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void SwitchToBuddyPlugin::switchToBuddy(bool)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">96</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QAction</span> <span class="o">*</span> <span class="n">action</span> <span class="o">=</span> <span class="n">qobject_cast</span><span class="o"><</span><span class="n">QAction</span><span class="o">*></span><span class="p">(</span><span class="n">sender</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, you could use a QSignalMapper for this instead of relying on sender() yourself. Would make the whole code a bit nicer even though it would mean storing the url as a string instead of as a KUrl.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I changed to a QSignalMapper. I _borrowed_ the code from the codeutils plugin. What are of the drawbacks of sender()? Besides it being quite implicit..</pre>
<br />
<p>- André</p>
<br />
<p>On November 13th, 2012, 3:16 p.m., André Stein wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By André Stein.</div>
<p style="color: grey;"><i>Updated Nov. 13, 2012, 3:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This request adds a new plugin "Switch to buddy" which enables in the c++ language plugin a new context menu action to switch to corresponding header or implementation file. This request is split in two parts because it needs changes in kdevelop too (see Request 107311).
Changes made:
- A new function has been added to IBuddyDocumentFinder to allow language plugins to implement logic to find buddy or related files.
- The new plugin "switch to buddy" implements a context menu extension which is only trigged if at least one buddy can be found. To get possible buddies IBuddyDocumentFinder is used using the editor's current document's mime type.
- See plugin
This implements a feature known from many IDEs. Using the Buddy interface and a separate plugin I think it's rather clean and generic.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual testing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/ibuddydocumentfinder.h <span style="color: grey">(7807df7)</span></li>
<li>plugins/CMakeLists.txt <span style="color: grey">(8aac3ae)</span></li>
<li>plugins/switchtobuddy/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/switchtobuddy/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/switchtobuddy/kdevswitchtobuddy.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/switchtobuddy/switchtobuddyplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/switchtobuddy/switchtobuddyplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/tests/shellbuddytest.cpp <span style="color: grey">(981daa3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107310/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107310/s/830/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/14/switch_screenshot1_400x100.png" style="border: 1px black solid;" alt="Context menu in action" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>