<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107311/">http://git.reviewboard.kde.org/r/107311/</a>
     </td>
    </tr>
   </table>
   <br />








<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On November 13th, 2012, 4:21 p.m., <b>Andreas Pakulat</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/107311/diff/1/?file=94717#file94717line537" style="color: black; font-weight: bold; text-decoration: underline;">languages/cpp/cpplanguagesupport.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QList< KUrl > CppLanguageSupport::getPotentialBuddies(const KUrl& url) const</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">537</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="k">return</span> <span class="n">QList</span><span class="o"><</span> <span class="n">KUrl</span> <span class="o">></span><span class="p">()</span> <span class="o"><<</span> <span class="n">KUrl</span><span class="p">(</span><span class="n">split</span><span class="p">.</span><span class="n">first</span> <span class="o">+</span> <span class="s">".c"</span><span class="p">)</span> <span class="o"><<</span> <span class="n">KUrl</span><span class="p">(</span><span class="n">split</span><span class="p">.</span><span class="n">first</span> <span class="o">+</span> <span class="s">".C"</span><span class="p">)</span> <span class="o"><<</span> <span class="n">KUrl</span><span class="p">(</span><span class="n">split</span><span class="p">.</span><span class="n">first</span> <span class="o">+</span> <span class="s">".cpp"</span><span class="p">)</span> <span class="o"><<</span> <span class="n">KUrl</span><span class="p">(</span><span class="n">split</span><span class="p">.</span><span class="n">first</span> <span class="o">+</span> <span class="s">".cc"</span><span class="p">);</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the knowledge about the extensions should be shared between this function and the areBuddies. In particular areBuddies currently does not seem to support c++ files or upper-case-C etc.</pre>
 </blockquote>



 <p>On November 14th, 2012, 8:12 a.m., <b>André Stein</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually areBuddies and this function both use the common function basePathAndType which determines the type of the source file (resulting in a 'h' or 'c' type). basePathAndType doesn't need to know all extensions because it just looks at the (lower-case) first character of the extension. So it also supports upper-case extensions. But it don't think it's really helpful to share more knowledge between those functions because they already use common basePathAndType.</pre>
 </blockquote>







</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, I see. Quite sneaky to name that "type" when its actually just a random character.

One more thing I just realize, maybe we could get the list of extensions which are to be considered buddies from the mimetype API? That is, fetch the mimetypes for text/x-csrc, text/x-c++src and corresponding *hdr types and then check which filename patterns are being setup. That way users have an easy way of configuring which files are considered buddies, which is sometimes nice if you have *.def files for enum-definitions or similar things.</pre>
<br />




<p>- Andreas</p>


<br />
<p>On November 13th, 2012, 3:16 p.m., André Stein wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDevelop.</div>
<div>By André Stein.</div>


<p style="color: grey;"><i>Updated Nov. 13, 2012, 3:16 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Second part of request 107310. This implements the C++ specific adaptions in Kdevelop. Must be merged together!</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>languages/cpp/cpplanguagesupport.h <span style="color: grey">(4053b18)</span></li>

 <li>languages/cpp/cpplanguagesupport.cpp <span style="color: grey">(60f8a63)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107311/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>