<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107277/">http://git.reviewboard.kde.org/r/107277/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 11th, 2012, 2:28 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The idea back then was to show that action as unobtrusive as possible. The way you have it now is pretty much in-your-face.
I agree of course that there are problems with the existing solution, esp. when you either edit near the bottom of the document, or if you change
something with multiple (long) options. Still, I'm not sure whether your way is optimal either...
Your implementation is esp. broken when you scroll the view while the popup is shown, as its position is not properly updated then.
I think I'll play a bit with it and see what I can come up with.
Cheers
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unobstrusive is of course a very valid key word. I'll also try my patch for daily work and see whether it improves work flow or rather reduces productivity.
Maybe we should take the same road as Eclipse: show a lightbulb in the left border when assistant actions are available and which upon click (or a special shortcut) actually shows the available options. I don't know how much effort this would be to implement but in the long there should be a solution which doesn't rely on a horizontal layout of the assistant popup as this limits the number of actions possible.
Cheers,
André</pre>
<br />
<p>- André</p>
<br />
<p>On November 10th, 2012, 1:25 p.m., André Stein wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By André Stein.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2012, 1:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I improved (at least IMO) the appearance of the assistant popup while editing code:
- I changed the layout of the popup to be vertically. Sometimes there are many actions in the popup which gives a rather crowded look. Additionally it sometimes doesn't fit on small screens (at least not on my 13" notebook).
- The placement has been changed to be oriented at the current cursor's position. The popup is placed 2 lines _under_ the currently edited line. If a line is edited at the bottom of the editor and the popup wouldn't fit into the window, it is placed _above_ the current line. That way a nasty magic number in the code can be removed too.
All in all I think this gives a better user experience. I had the feeling that some users didn't even see the popup because it was placed at the editor's bottom and so was out of the current "code focus". Additionally the vertical layout matches the behaviour which is seen in other IDEs like Qt Creator or Eclipse.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual testing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/assistantpopup.h <span style="color: grey">(42c55e4)</span></li>
<li>shell/assistantpopup.cpp <span style="color: grey">(44a4538)</span></li>
<li>shell/uicontroller.cpp <span style="color: grey">(2c0400f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107277/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107277/s/817/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/10/under_400x100.png" style="border: 1px black solid;" alt="Popup under code" /></a>
<a href="http://git.reviewboard.kde.org/r/107277/s/818/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/10/above_400x100.png" style="border: 1px black solid;" alt="Popup when space is limited (above)" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>