<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107236/">http://git.reviewboard.kde.org/r/107236/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Aleix Pol Gonzalez.</div>
<div>By Kevin Funk.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix crash caused by wrong usage of STL iterators
Before this patch it might have been possible to iterate beyond the
end() of the hash(es).
Also see 'erase' in http://doc.qt.digia.com/qq/qq12-qt4-iterators.html.
Regression introduced by: 227a8456
BUG: 309442
BT:
(...)
10 0x00007ff556999af3 in qt_assert_x (where=0x7ff556b6778a "QHash",
what=0x7ff556b67773 "Iterating beyond end()", file=0x7ff556b67740
"/home/krf/devel/src/qt/src/corelib/tools/qhash.cpp", line=293) at
/home/krf/devel/src/qt/src/corelib/global/qglobal.cpp:2021
11 0x00007ff5569cbdfd in QHashData::nextNode (node=0x9b3e7e0) at
/home/krf/devel/src/qt/src/corelib/tools/qhash.cpp:293
12 0x00007ff5255211fc in QHash<KUrl, KUrl>::iterator::operator++
(this=this@entry=0x7fffce6aa370) at
/home/krf/devel/build/qt4.8-shared-debug/include/QtCore/../../../../src/qt/src/corelib/tools/qhash.h:355
13 0x00007ff52551ada4 in CMakeManager::cleanupToDelete
(this=this@entry=0x5cfdda0, p=0x8cedfe0) at
/home/krf/devel/src/kdevelop/projectmanagers/cmake/cmakemanager.cpp:1150
(...)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectmanagers/cmake/cmakemanager.cpp <span style="color: grey">(ce65427a14d4dbde04e16c0c9acc73d90d995fbc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107236/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>