<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107158/">http://git.reviewboard.kde.org/r/107158/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 4th, 2012, 6:52 p.m., <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't really know much about this code-base, but still I don't understand the patch that much.
First of all, why is this patch removing all those files? It may be possible that they're unneeded, but it should be done in a different patch.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> First of all, why is this patch removing all those files? It may be possible that they're unneeded, but it should be done in a different patch.
those files are indeed unneeded and should be deleted to avoid confusion. This is unrelated to this patch of course.
I pushed that just now.</pre>
<br />
<p>- Niko</p>
<br />
<p>On October 31st, 2012, 4:31 p.m., Enver Haase wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Niko Sams.</div>
<div>By Enver Haase.</div>
<p style="color: grey;"><i>Updated Oct. 31, 2012, 4:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used together with my patch for KDevPlatform.
Closes https://bugs.kde.org/show_bug.cgi?id=257343
making watched debugger variables user-editable.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=257343">257343</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debuggers/gdb/_abstractvariableitem.h <span style="color: grey">(9ccdd03)</span></li>
<li>debuggers/gdb/_abstractvariableitem.cpp <span style="color: grey">(4502393)</span></li>
<li>debuggers/gdb/_variableitem.h <span style="color: grey">(8285d1f)</span></li>
<li>debuggers/gdb/_variableitem.cpp <span style="color: grey">(4cd3921)</span></li>
<li>debuggers/gdb/_watchitem.h <span style="color: grey">(3e26038)</span></li>
<li>debuggers/gdb/_watchitem.cpp <span style="color: grey">(83eecd3)</span></li>
<li>debuggers/gdb/gdbvariable.h <span style="color: grey">(9a6fb11)</span></li>
<li>debuggers/gdb/gdbvariable.cpp <span style="color: grey">(a98e25d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107158/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>