<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107071/">http://git.reviewboard.kde.org/r/107071/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Niko,
the suggested fix seems to be incorrect. This is what the code should do:
* While there are less than position+k+1 tokens in the stream
** generate missing tokens (for example by using a lexer or by adding EOFs if you are at the end)
* Return the token at position+k
Instead, the default implementation of kdev-pg-token-stream.h should be fixed: It should generate EOFs if there are no more tokens in the stream. I will test that.
Regards</pre>
<br />
<p>- Jonathan</p>
<br />
<p>On October 27th, 2012, 1:34 p.m., Niko Sams wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Jonathan Schmidt-Dominé.</div>
<div>By Niko Sams.</div>
<p style="color: grey;"><i>Updated Oct. 27, 2012, 1:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I found an issue with the LA method generated by kdevelop-pg-qt, this patch fixes it.
If the patch gets accepted we should release a new version of kdevelop-pg-qt.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">unittest in kdev-css shows the issue:
./parser/parsertest "parser:missing closing brace"
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdev-pg/kdev-pg-code-gen.cpp <span style="color: grey">(e06c6be)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107071/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>