<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107112/">http://git.reviewboard.kde.org/r/107112/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 29th, 2012, 2:48 p.m., <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually I'm unsure that we need this, this dialog is never shown because we have reviewpatch. Maybe we shouldn't have that?
Also probably it would be worth considering to crate a vcs ui plugin, so that the plugins only have to provide the UI they want to add (right now they all do throw the vcspluginhelper, and it doesn't seem a logical way to do it...)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Anyway, some code is needed to handle the case when "IPatchReview* review == 0"... Of course, we may just print a nasty error message in that case.
And regarding vcspluginhelper: I'm afraid that I don't understand you... and I'm not very confident with the overall system architecture - but I see that the vcspluginhelper is used just to provide the default context menu actions, and it seems to do that well.
// BTW, some plugins (say, Git) do not refer to the helper at all, but still get these default context menus - how's that accomplished?</pre>
<br />
<p>- Ivan</p>
<br />
<p>On October 29th, 2012, 2:26 p.m., Ivan Shapovalov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Ivan Shapovalov.</div>
<p style="color: grey;"><i>Updated Oct. 29, 2012, 2:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As stated in subject (VcsDiffWidget -> VcsDiffDialog and inherit from KDialog).
Also stop the dialog from appearing in the vcs history dialog when there is a patchreview plugin available.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/subversion/kdevsvnplugin.cpp <span style="color: grey">(560982e)</span></li>
<li>vcs/CMakeLists.txt <span style="color: grey">(60fc7e9)</span></li>
<li>vcs/widgets/vcsdiffdialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>vcs/widgets/vcsdiffdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>vcs/widgets/vcsdiffdialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>vcs/widgets/vcsdiffwidget.h <span style="color: grey">(aabc783)</span></li>
<li>vcs/widgets/vcsdiffwidget.cpp <span style="color: grey">(54787b9)</span></li>
<li>vcs/widgets/vcsdiffwidget.ui <span style="color: grey">(ccde3a0)</span></li>
<li>vcs/widgets/vcseventwidget.cpp <span style="color: grey">(5abad09)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107112/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>