<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106812/">http://git.reviewboard.kde.org/r/106812/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 15th, 2012, 3:51 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">while I'm OK with that, I wonder whether not maybe Kasten itself should have a proper define to check that... anyhow, just commit it</pre>
</blockquote>
<p>On October 15th, 2012, 5:05 p.m., <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, I guess thats whats happening already and hence the factory etc. is not available causing kdevelop to fail to build with such a Kasten library. Whats not so nice IMO is that this is based on endianess only, it would be nicer to keep that part in kasten and have kasten advertise via cmake variables which stuff was included when it was built or via a header which sets defines like NO_STRUCTURES_VIEW. Then kdevelop would only include the structures factory if it was included in kasten, no matter what reason there was to not include it (there may be other reasons than just endinaness).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So is that a yes or a no? :-)
(I note that the only reason for checking endianness here is because that's what kasten does)</pre>
<br />
<p>- Michael</p>
<br />
<p>On October 12th, 2012, 3:11 p.m., Michael Palimaka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Michael Palimaka.</div>
<p style="color: grey;"><i>Updated Oct. 12, 2012, 3:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch (from Fedora) disables the structures tool on big endian systems, as the required library is not supported:
# temporary check for broken code in the Structures tool with bigendianness
include(TestBigEndian)
test_big_endian(BIG_ENDIAN)
if (BIG_ENDIAN)
set( NO_STRUCTURES_TOOL TRUE )
endif (BIG_ENDIAN)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>utils/okteta/oktetaplugin.cpp <span style="color: grey">(5691959629f9fc8a6a9a8f518f6c8b9bf63e9cf4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106812/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>