Hi Morten,<br><br>I will not be hacking much in KDE - I'm a fortran guy, not C++ :-)) So before I add an account and all I would ask if you perhaps would to look at the (fairly trivial) changes I made? And if they are OK push them into the master branch. I'm new to git as well, so I dont really get it regarding pushing changes...<br>
<br>I believe that the files attached are OK ('modified_files.tar.gz') - if you want the diff it is in 'diff_origin_master.txt'. I've modified the tests as well, and they run without errors.<br><br>One thing I dont understand is that it does NOT work for gfortran in kdevelop! (see Screenshot_kdev.png). It does not highlight and I cant jump in code. If you install gfortran it should be strainght forward to open the Cmake-mini-test_f (in 'test_f.tar.gz') I've made.<br>
<br>It is only gfortran thats a problem - intel fortran works like a charm with highlighting as well as jumping to the correct places in the code.<br><br>Thanks for your help!<br><br>Best regards <br><br>Peter <br><br><br>
<br><br><div class="gmail_quote">2012/10/15 Morten Volden <span dir="ltr"><<a href="mailto:mvolden2@gmail.com" target="_blank">mvolden2@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Peter <br><br>As far as I know the re-factoring of the output filtering is not in the 4.4. branch, so when you say 4.4. branch I assume you mean master. <br><br>The ErrorFormat class constructors looks like this:<br><br>
<pre>ErrorFormat( <span>const</span> QString& regExp, <span>int</span> file, <span>int</span> line, <span>int</span> text, <span>int</span> column=-<span>1</span> );<br>
ErrorFormat( <span>const</span> QString& regExp, <span>int</span> file, <span>int</span> line, <span>int</span> text, <span>const</span> QString& comp, <span>int</span> column=-<span>1</span> );<br>
</pre>The 'file', 'line', 'text', and 'column' integers indicate what group in the regExp that information is found (for example the file information is found in the second pair of parentheses in the regular expression in the ErrorFormat constructor below.)<br>
<br>I am not near my workstation right now so I cannot say for certain, but something like the ErrorFormat constructor below should work (In master).<br><br>ErrorFormat( <span><span>"</span></span><span><span><code><span style="color:#000066">^fortcom: ([a-zA-Z]+): (.*), line ([0-9]+):(.*)</span></code></span><span>"</span></span>, <span>2</span>, <span>3</span>, <span>1</span>, <span><span>"</span><span>intel</span><span>"</span></span> )<code><span style="color:#000066"><br>
</span></code><br>In the outputview/test directory there is a file called filteringstrategytest.cpp. I highly recommend that you implement a unittest for your case there. <br><br>Once you have a working patch and test in place, you can use kdevelop to post that on <a href="http://git.reviewboard.kde.org" target="_blank">git.reviewboard.kde.org</a><br>
<br>Hope this helps<br><br>/Morten<br>
<br><div class="gmail_quote">2012/10/15 Peter M. Clausen <span dir="ltr"><<a href="mailto:petermichaelclausen@gmail.com" target="_blank">petermichaelclausen@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div class="h5">
sorry - I used the wrong list...<div><div><br><br><div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Peter M. Clausen</b> <span dir="ltr"><<a href="mailto:petermichaelclausen@gmail.com" target="_blank">petermichaelclausen@gmail.com</a>></span><br>
Date: 2012/10/15<br>Subject: Issues parsing buildoutput<br>To: <a href="mailto:kdevelop@kdevelop.org" target="_blank">kdevelop@kdevelop.org</a><br><br><br>Hi<div><br></div><div>I'm working with kdevelop 4.3.1 (Ubuntu 12.04). I was trying to fix an issue parsing intel fortran (ifort) build output. I am able to do so in 4.3.1 branch, but not in 4.4. (latest) branch.</div>
<div>
<br></div><div>Problem using Intel Fortran: "Info" output cannot be 'clicked' on and let cursor jump to problematic place. "Error" is OK.</div><div><br></div><div>I looked into the file kdevelop-4.3.1/projectbuilders/makebuilder/outputfilters.cpp line 38:</div>
<div> org:</div><div> << ErrorFormat( "fortcom: (.*), line ([0-9]+):(.*)", 1, 2, 3, "intel" )</div><div><br></div><div><div> new:</div><div> << ErrorFormat( "[a-zA-Z]+: [a-zA-Z]+: (.*), line ([0-9]+):(.*)", 1, 2, 3, "intel" )</div>
</div><div><br></div><div>Thus it will match both following lines:</div><div><div><div>fortcom: Error: /scratch/var_r_en.f90, line 292: Syntax error, found ')' when expecting one of: ( <IDENTIFIER> <CHAR_CON_KIND_PARAM> <CHAR_NAM_KIND_PARAM> <CHARACTER_CONSTANT> <INTEGER_CONSTANT> ...</div>
<div> if (record_exists==)</div></div><div>fortcom: Info: /scratch/var_r_en.f90, line 101: This variable has not been used. [D]</div><div> real D</div></div><div><div><br></div></div><div><br></div><div>I tried to look at this in 4.4. branch (<a href="http://anongit.kde.org/kdevplatform/kdevplatform-latest.tar.gz" target="_blank">http://anongit.kde.org/kdevplatform/kdevplatform-latest.tar.gz</a>) and it looks like it has been moved to: ./kdevplatform/outputview/outputfilteringstrategies.cpp</div>
<div>But here I cant make it work. I've changed the line 88:</div><div><div> org: </div><div> << ErrorFormat( "^fortcom: (Error): (.*), line ([0-9]+):(.*)", 2, 3, 1, "intel" )</div><div>
new:</div><div> << ErrorFormat( "^[a-zA-Z]+: [a-zA-Z]+: (.*), line ([0-9]+):(.*)", 1, 2, 3, "intel" )</div></div><div><br></div><div>But it does not work as in 4.3.1. Doing the above change only matches the first error, not any info or any other errors afterwards. Could someone please help me here? I was also wondering why "2, 3, 1" should be the new order of arguments, compare to 4.3.1 branch.</div>
<div><br></div><div>I have never submitted anything to a KDE-project, so I would be thankfull if someone could point me to a "how to".</div><div><br></div><div>Best regards</div><span><font color="#888888"><div>
<br></div><div>Peter</div></font></span><div>
<br></div><div>PS. Keep up the good work on my favorite IDE.</div>
</div><br>
</div></div><br></div></div><span class="HOEnZb"><font color="#888888">--<br>
KDevelop-devel mailing list<br>
<a href="mailto:KDevelop-devel@kdevelop.org" target="_blank">KDevelop-devel@kdevelop.org</a><br>
<a href="https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel" target="_blank">https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel</a><br>
<br></font></span></blockquote></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><br>-- <br>- When the split is pulled, mr. Grenade is no longer our friend<br>
</font></span><br>--<br>
KDevelop-devel mailing list<br>
<a href="mailto:KDevelop-devel@kdevelop.org">KDevelop-devel@kdevelop.org</a><br>
<a href="https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel" target="_blank">https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel</a><br>
<br></blockquote></div><br>