<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106848/">http://git.reviewboard.kde.org/r/106848/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 14th, 2012, 10:43 p.m., <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For this, you can use KFilterProxySearchLine, it probably be less code and maybe you won't have to expose the line edit as a constructor parameter, I guess...</pre>
</blockquote>
<p>On October 15th, 2012, 6:13 p.m., <b>Niko Sams</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">hm, doesn't save much code. It also doesn't handle selection with up/down. But I'll change to use that class.</pre>
</blockquote>
<p>On October 15th, 2012, 6:17 p.m., <b>Niko Sams</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh, and this class has one downside: it buffers textchanges; so the filter is applied after 300ms.
While this perfectly makes sense for large lists it's rather annoying here. I'd prefer to not use it.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see, well 300ms shouldn't be noticeable. In any case, if you don't think it's a good idea, then I trust you :).
Why don't you put the lineedit on top? Also you can put a "Filter:" label at the left, so that one can see what's going to happen. Having a Click message would be useful as well.</pre>
<br />
<p>- Aleix</p>
<br />
<p>On October 14th, 2012, 2:08 p.m., Niko Sams wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Niko Sams.</div>
<p style="color: grey;"><i>Updated Oct. 14, 2012, 2:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a QLineEdit below sessions view that filters the list of sessions. Up and Down keys are handled so you can navigate using them in the list without having to focus it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">run kdevelop -ps</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/sessioncontroller.cpp <span style="color: grey">(c9fac67)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106848/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106848/s/770/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/14/pick-session-filter_400x100.png" style="border: 1px black solid;" alt="Pick Session Filter" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>