<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106508/">http://git.reviewboard.kde.org/r/106508/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 7th, 2012, 3:19 p.m., <b>David Nolden</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've implemented this a bit differently now so that it has the bidirectional switching functionality. Thank you for the patch. You did many changes in parameter-escaping, can you explain these a bit? If those fix some bugs, please submit them separately based on the current trunk.</pre>
</blockquote>
<p>On October 7th, 2012, 4:56 p.m., <b>Ivan Shapovalov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The quotes around variable assignments and parameters fix potential bugs with paths containing spaces. (And the ones around network port/username variables are there just for the sake of completeness.)
IMO, quoting what one wants to be a single parameter/word is always a good idea when writing in shell... If you ACK, I'll post a separate patch (maybe for all shell scripts that we have).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shell scripting isn't my strong side, I don't even like it, so patches improving the robustness are of course welcome. However it has to be made sure that no regressions are introduced, unfortunately there are no tests for the shell integration yet.</pre>
<br />
<p>- David</p>
<br />
<p>On September 27th, 2012, 5 p.m., Ivan Shapovalov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Ivan Shapovalov.</div>
<p style="color: grey;"><i>Updated Sept. 27, 2012, 5 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds 2 new commands for syncing the shell working directory (in kdevplatform_shell_environment.sh).
These are
- "project!", which navigates to the root directory of a project, and
- "bdir!", which navigates to the build directory of a project (if one is returned by the build manager), using shell's cwd (if in source tree) to find the corresponding subdirectory in the build tree.
These commands take an optional argument - project name, which (if exists) is handled as a target project name prefix and is collated in case-insensitive mode.
Thus, to navigate to kdevplatform's root directory one may type "project! kdevpl".
If that argument is not given, the project of currently open document is selected.
Reason: I just found these commands useful. Maybe someone else also will.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used the newly-added commands for a sufficiently long time period (~2 weeks).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/projectcontroller.h <span style="color: grey">(e21345f)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(bc557bd)</span></li>
<li>util/kdevplatform_shell_environment.sh <span style="color: grey">(d428f6c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106508/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>