<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105691/">http://git.reviewboard.kde.org/r/105691/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Moved the tabs back to the top now due to the broken ui when the dialog is not high enough.</pre>
<br />
<p>- Andreas</p>
<br />
<p>On August 31st, 2012, 6:44 a.m., Ivan Shapovalov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Andreas Pakulat.</div>
<div>By Ivan Shapovalov.</div>
<p style="color: grey;"><i>Updated Aug. 31, 2012, 6:44 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changes done:
1) Pass current project to the UI and pathes model.
-> reasoning: they use it to relativize URLs
2) last-item-placeholders in pathes- and includes-model replaced by add*() methods
-> reasoning: UI will use URL requesters to add new items
3) add a persistent (undeleteable; attempts to change its path result in creation of another item) "project root" item to the pathes model
-> reasoning: usability - many people will want to do common per-project settings
4) make project pathes model URL-aware: clean/relativize pathes on adding, introduce custom roles to get full pathes/URLs
-> reasoning: usability
UI modifications done:
5) replace listview of sub-project pathes with a combobox URL requester
-> reasoning: less on-screen space
6) Replace stacked widget for includes/defines selection with a tab-interface.
-> reasoning: usability - one can see all choices (includes and defines, maybe language features when they are merged) at once instead of having to open the combobox.
7) Use URL requesters and add/remove buttons instead of "Double-Click here..." placeholders.
-> reasoning: usability - one may select a path without having to type it.
8) Add a button to remove selected include/define
-> reasoning: in comments
9) Change various labels and popup texts
-> reasoning: on-screen readability.
10) Clear inner UI on config set rather than before config loading.
-> reasoning: robustness (when new configuration is selected, UI is cleared and refilled from scratch instead of overwriting old data).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual testing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>configwidget.h <span style="color: grey">(ce9ba32)</span></li>
<li>configwidget.cpp <span style="color: grey">(38bc551)</span></li>
<li>configwidget.ui <span style="color: grey">(d411d83)</span></li>
<li>custombuildsystemconfig.h <span style="color: grey">(62901d4)</span></li>
<li>custombuildsystemconfigwidget.h <span style="color: grey">(d94e9fc)</span></li>
<li>custombuildsystemconfigwidget.cpp <span style="color: grey">(791b7c7)</span></li>
<li>includesmodel.h <span style="color: grey">(debf278)</span></li>
<li>includesmodel.cpp <span style="color: grey">(ab42e16)</span></li>
<li>kcm_custombuildsystem.cpp <span style="color: grey">(2f222bf)</span></li>
<li>projectpathsmodel.h <span style="color: grey">(d32bb92)</span></li>
<li>projectpathsmodel.cpp <span style="color: grey">(6ee35b7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105691/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105691/s/654/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/30/old_ui_400x100.png" style="border: 1px black solid;" alt="Before changes" /></a>
<a href="http://git.reviewboard.kde.org/r/105691/s/655/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/30/new_ui_idle_400x100.png" style="border: 1px black solid;" alt="New UI - idle" /></a>
<a href="http://git.reviewboard.kde.org/r/105691/s/656/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/30/new_ui_idle_editing_400x100.png" style="border: 1px black solid;" alt="New UI - editing project path" /></a>
<a href="http://git.reviewboard.kde.org/r/105691/s/712/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/31/side_400x100.png" style="border: 1px black solid;" alt="Unusable tab-bar at the side" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>