<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105985/">http://git.reviewboard.kde.org/r/105985/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 12th, 2012, 9:02 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">not knowing anything about windows, is InfoZIP the default? Are there other ZIP implementations? Do they continue to work?</pre>
</blockquote>
<p>On August 12th, 2012, 10:39 p.m., <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is nothing like a standard zip tool on Windows, windows doesn't ship one so everybody downloads one from somewhere. And yes this change can break the commandline for other zip tools if they have different requirements. So basically someone has to write find-modules for one or multiple zip-tools that should be supported and setup the commandline accordingly. Alternatively one could write a small utility using the KDE classes that are also used for extraction which is built as part of kdevplatform/internal or so and then used for packaging the templates.</pre>
</blockquote>
<p>On August 13th, 2012, 1:55 a.m., <b>Steffen Ohrendorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">InfoZIP is the one that comes with the emerge tool of the winkde project, and also the "zip" on the linux machine I'm using (OpenSUSE 12.1) is InfoZIP, so I guessed that would be the standard tool.</pre>
</blockquote>
<p>On August 13th, 2012, 1:47 p.m., <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can someone check what the kde-runtime binary package from the windows installer provides, i.e. does it even install (itself or via dependencies) a zip utility? I was mostly concerned about that case, i.e. someone wanting to use kdevelop installs it via binary package and has some other zip-tool installed hits problems because the commandline needs to be different.
FWIW my zip on a non-KDE windows box is also info-zip. So if someone can confirm that info-zip is installed via the binary packages then I think the change can go in.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I grep'ed all the archives the installer had downloaded, and zip is not included, but bzip2 is, though tar is unfortunately not included. But AFAIK that would be only a dependency problem, because the emerge tool that actually builds the binary packages downloads infozip, though I haven't found it on http://winkde.org/pub/kde/ports/ -- which either means that there are licensing problems or that the winKDE team simply thought that the binary releases do not need zip. Maybe someone should ask them to include either tar or infozip as an additional dependency.</pre>
<br />
<p>- Steffen</p>
<br />
<p>On August 11th, 2012, 9:18 p.m., Steffen Ohrendorf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Steffen Ohrendorf.</div>
<p style="color: grey;"><i>Updated Aug. 11, 2012, 9:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes the invocation of InfoZIP on Windows which requires the exclusion parameter to be the last one on the command line.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KDevPlatform successfully zips the app templates.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/KDevPlatformMacros.cmake <span style="color: grey">(f960e82)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105985/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>