<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105307/">http://git.reviewboard.kde.org/r/105307/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 20th, 2012, 1:52 p.m., <b>Alexandre Courbot</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">FYI 8 of the tests in testPreprocessor() were failing before this patch. The test added also fails because variadic arguments are not correctly expanded in the first place.</pre>
</blockquote>
<p>On June 25th, 2012, 10:40 a.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">locally I don't have any failing tests - so please take a look at that again.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Milian, sorry for the late reply. Here is the result of testPreprocessor on today's master branch:
./parsertest testPreprocessor
********* Start testing of TestParser *********
Config: Using QTest library 4.8.2, Qt 4.8.2
QWARN : TestParser::initTestCase() WARNING: deleting stale lockfile /home/gnurou/.kde4/share/apps/kdevplatform/sessions//{e67c062e-a374-42c2-a842-fce5a902a3c2}/lock
QWARN : TestParser::initTestCase() WARNING: deleting stale lockfile /home/gnurou/.kdevduchain/{e67c062e-a374-42c2-a842-fce5a902a3c2}/0/lock
QDEBUG : TestParser::initTestCase() kdevplatform(32374)/kdevplatform (language) KDevelop::ItemRepositoryRegistry::open: version-hint not found, seems to be an old version
QDEBUG : TestParser::initTestCase() kdevplatform(32374)/kdevplatform (language) KDevelop::ItemRepositoryRegistry::open: "The data-repository at /home/gnurou/.kdevduchain/{e67c062e-a374-42c2-a842-fce5a902a3c2}/0 has to be cleared."
PASS : TestParser::initTestCase()
XFAIL : TestParser::testPreprocessor() Backslash incorrectly handled
Loc: [/home/gnurou/Work/KDE/kdevelop/languages/cpp/parser/tests/test_parser.cpp(509)]
XFAIL : TestParser::testPreprocessor() Backslash incorrectly handled
Loc: [/home/gnurou/Work/KDE/kdevelop/languages/cpp/parser/tests/test_parser.cpp(512)]
XFAIL : TestParser::testPreprocessor() Empty expansions incorrectly handled
Loc: [/home/gnurou/Work/KDE/kdevelop/languages/cpp/parser/tests/test_parser.cpp(515)]
XFAIL : TestParser::testPreprocessor() Variadic macros unsupported
Loc: [/home/gnurou/Work/KDE/kdevelop/languages/cpp/parser/tests/test_parser.cpp(518)]
XFAIL : TestParser::testPreprocessor() Variadic macros unsupported
Loc: [/home/gnurou/Work/KDE/kdevelop/languages/cpp/parser/tests/test_parser.cpp(521)]
XFAIL : TestParser::testPreprocessor() No problems reported for missmatching macro-parameter-lists
Loc: [/home/gnurou/Work/KDE/kdevelop/languages/cpp/parser/tests/test_parser.cpp(524)]
XFAIL : TestParser::testPreprocessor() No problems reported for missmatching macro-parameter-lists
Loc: [/home/gnurou/Work/KDE/kdevelop/languages/cpp/parser/tests/test_parser.cpp(527)]
XFAIL : TestParser::testPreprocessor() No problems reported for macro-redefinition
Loc: [/home/gnurou/Work/KDE/kdevelop/languages/cpp/parser/tests/test_parser.cpp(530)]
PASS : TestParser::testPreprocessor()
PASS : TestParser::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped
********* Finished testing of TestParser *********
As you can see some errors are indeed triggered, even though no test is mentionned as failed in the end.</pre>
<br />
<p>- Alexandre</p>
<br />
<p>On June 20th, 2012, 1:51 p.m., Alexandre Courbot wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexandre Courbot.</div>
<p style="color: grey;"><i>Updated June 20, 2012, 1:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In GNU C, the variadic argument of a macro can be completely left out
without triggering an error (as explained in
http://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Checked that the faulty case was not triggering a parsing error anymore. Checked that no regression was introduced in the testPreprocessor() test case.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/parser/rpp/pp-engine.cpp <span style="color: grey">(ca566cb)</span></li>
<li>languages/cpp/parser/tests/test_parser.cpp <span style="color: grey">(804f379)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105307/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>