<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105505/">http://git.reviewboard.kde.org/r/105505/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Definitely an improvement in my opinion, still, the main problem with the dialog is the launch type which is totally unfindable. It should really be moved to the right. This can probably be done later just as well, tough.</pre>
<br />
<p>- Sven</p>
<br />
<p>On July 10th, 2012, 2:50 p.m., Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated July 10, 2012, 2:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Following the KDevelop BoF, I worked a bit on the "configure launch" dialog.
Changes are:
- Remove multiple margins
- Reworked layout: getting rid of some labels, adding labels to buttons
- Simplify "Add" button menu when possible: if the first and second levels are only made of one item, directly show the third level. If only the first level is one-item, show the second and third level.
This patch could have been broken in multiple parts (they are individual commits in my work branch), but I was a bit too lazy to file them separately :/
Further possible improvements:
- the "Add" button could be simplified a bit more by always showing the menu, but I may be missing a case where adding an empty launch is useful.
- the "launch" name is currently editable through the tree view only, I think it should rather be a field in the detail part.
- the way to pick the executable could be simplified by only showing the target combobox by default. The combobox would have an additional "custom" entry, which when selected would show a lineedit to let the user enter the executable name.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with one project and multiple projects in one session.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/execute/nativeappconfig.ui <span style="color: grey">(3496edd)</span></li>
<li>shell/launchconfigurationdialog.cpp <span style="color: grey">(372510a)</span></li>
<li>shell/launchconfigurationdialog.ui <span style="color: grey">(d287077)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105505/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105505/s/619/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/10/relayout_400x100.png" style="border: 1px black solid;" alt="Relayout" /></a>
<a href="http://git.reviewboard.kde.org/r/105505/s/620/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/10/simplified-menu_400x100.png" style="border: 1px black solid;" alt="Simplified "add" menu" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>