<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105321/">http://git.reviewboard.kde.org/r/105321/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Andreas</p>
<br />
<p>On July 7th, 2012, 11:13 a.m., Morten Volden wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Morten Volden.</div>
<p style="color: grey;"><i>Updated July 7, 2012, 11:13 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is related to: http://git.reviewboard.kde.org/r/104814/
(Share code between makebuilder and external scripts). It uses the outputmodel defined in outputview/outputmodel and removes makeoutputmodel.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ported the tests from makeoutputmodel to outputview/outputmodel and outputview/filteringstrategies</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectbuilders/makebuilder/CMakeLists.txt <span style="color: grey">(1674533)</span></li>
<li>projectbuilders/makebuilder/makebuilder.h <span style="color: grey">(131324d)</span></li>
<li>projectbuilders/makebuilder/makebuilder.cpp <span style="color: grey">(b504a22)</span></li>
<li>projectbuilders/makebuilder/makejob.h <span style="color: grey">(2cb7ef9)</span></li>
<li>projectbuilders/makebuilder/makejob.cpp <span style="color: grey">(147dbfb)</span></li>
<li>projectbuilders/makebuilder/makeoutputdelegate.h <span style="color: grey">(a33a4ca)</span></li>
<li>projectbuilders/makebuilder/makeoutputdelegate.cpp <span style="color: grey">(688ec3c)</span></li>
<li>projectbuilders/makebuilder/makeoutputmodel.h <span style="color: grey">(a088267)</span></li>
<li>projectbuilders/makebuilder/makeoutputmodel.cpp <span style="color: grey">(d2fdfb4)</span></li>
<li>projectbuilders/makebuilder/outputfilters.h <span style="color: grey">(0b8b9d0)</span></li>
<li>projectbuilders/makebuilder/outputfilters.cpp <span style="color: grey">(1017de0)</span></li>
<li>projectbuilders/makebuilder/tests/CMakeLists.txt <span style="color: grey">(bb16aca)</span></li>
<li>projectbuilders/makebuilder/tests/test_makeoutputmodel.h <span style="color: grey">(0f5c8ce)</span></li>
<li>projectbuilders/makebuilder/tests/test_makeoutputmodel.cpp <span style="color: grey">(5955c6b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105321/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>