<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105211/">http://git.reviewboard.kde.org/r/105211/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 11th, 2012, 8:01 a.m., <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Obviously didn't look at the C++ code, but I can't see any major problems with the cmake code.
However I'd suggest you drop the version-numbering from your libraries and public API. This does simply not scale and would also be unecessary when the libs installed a cmake-config-file and a pkgconfig file. With that the majority of buildsystems out there would have very easy ways to ensure that a specific version is found and headers and libraries from the same version are being used. Even with the find-files there are now, one could do a quick try-compile check to verify that the headers found match the libraries.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, writing this patch I rolled my eyes a few times (as well I guess) :) And also raised my fist another time against the Qt signal/slot implementation ;)
But then...
The reason for that version-numbering of the libraries and public API is that I want to support the parallel install of different Kasten versions and even the loading of plugins which use different versions of Kasten into the same process (as I experiment a lot with Kasten I have that at least locally, like a few KParts build on older Kasten versions, as I didn't schedule the time to always port them to the latest). And because Kasten is still far from being near a stable API, every release of Okteta comes with a new version of Kasten (the Okteta core/gui libs as slightly more stable, but then I have a few issues there as well).
So to prevent clashes with include files, library file links and library symbols I turned to the solution with the version-numbering of the API and the library name, like I have seen it e.g. with glib (just that they do not break their API every half a year :) )
If there is a better solution, I am all ears to learn about that.
Installing cmake-config-file and a pkgconfig file is still a good idea, will see to add that to the Okteta/Kasten libs.</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On June 11th, 2012, 4:50 a.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated June 11, 2012, 4:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Of course the upcoming Okteta 0.9 again has a different API, so the Okteta plugin will not be build with it. Unless this patch is committed :)
Needs at least kdesdk from svn commit 1299667. The SC 4.9 beta2 tarballs, unless rerolled, miss an installed header, so if relying on packages, the only upcoming beta3/rc1 packages are needed.
Backport to 4.3 currently blocked by the messed 4.3 branch, but might be a simple cherry-pick. Okay to also backport and commit, once the 4.3 branch is cleared again? Backport with or without the one string addition?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Opened a few files as byte arrays, edited and changed view profiles.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindLibKasten.cmake <span style="color: grey">(087eedc)</span></li>
<li>cmake/modules/FindLibOktetaKasten.cmake <span style="color: grey">(973f0f1)</span></li>
<li>utils/CMakeLists.txt <span style="color: grey">(1545d8c)</span></li>
<li>utils/okteta/kastentoolviewwidget.cpp <span style="color: grey">(b10974e)</span></li>
<li>utils/okteta/kdevokteta.rc <span style="color: grey">(e5314cf)</span></li>
<li>utils/okteta/oktetadocument.h <span style="color: grey">(56eba46)</span></li>
<li>utils/okteta/oktetadocument.cpp <span style="color: grey">(abb047d)</span></li>
<li>utils/okteta/oktetaglobal.h <span style="color: grey">(0113bbb)</span></li>
<li>utils/okteta/oktetaplugin.h <span style="color: grey">(3eec9f7)</span></li>
<li>utils/okteta/oktetaplugin.cpp <span style="color: grey">(c8a7fd4)</span></li>
<li>utils/okteta/oktetatoolviewfactory.cpp <span style="color: grey">(ed0cf13)</span></li>
<li>utils/okteta/oktetaview.h <span style="color: grey">(29a6b39)</span></li>
<li>utils/okteta/oktetaview.cpp <span style="color: grey">(249aaaa)</span></li>
<li>utils/okteta/oktetawidget.h <span style="color: grey">(dfc9907)</span></li>
<li>utils/okteta/oktetawidget.cpp <span style="color: grey">(0fac371)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105211/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>