<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105067/">http://git.reviewboard.kde.org/r/105067/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Milian Wolff.</div>
<div>By Raphael Kubo da Costa.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Look for ext/hash_map and unordered_map instead of checking gcc's version.
Follow-up to commits 9f8e8f662974a1035ea64f0ab9404b8858a02a57 and
5c59bd61b1df1b963959f086c5202689c084e0f3. The decision of whether to
include <ext/hash_map> or <unordered_map> for gcc/clang was based on
whether gcc > 4.3 was installed or whether clang was being used. The
latter implicitly assumed a recent enough libstdc++ version (ie. >=
4.3) was being used, which might not be the case on systems such as
FreeBSD and possibly OS X.
Instead of checking for compiler versions, we now look for these
headers: CMake first detects whether <unordered_map> is present and,
in case it is not, it looks for <ext/hash_map>. The checks in
languages/cpp/parser/parser.h have been updated as well. This should
cover all the cases being previously detected, as well as fix the
checks for FreeBSD and other systems where the build was failing
before with clang.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Was able to build KDevelop with clang and libstdc++ 4.2.1 on FreeBSD. I would appreciate if people could test this patch on Linux with a more recent libstdc++</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(8a3be2181642d0af6e3660d52948bd24d3f8cb4a)</span></li>
<li>config.h.cmake <span style="color: grey">(0c41fe4203dc39f4ff1e03b8b77211c7148a9bec)</span></li>
<li>languages/cpp/CMakeLists.txt <span style="color: grey">(1577a7baffc3af052c62a075eced8d09750fdf53)</span></li>
<li>languages/cpp/parser/parser.h <span style="color: grey">(c5198912bbf83a46bc89b1595d68b71e0a9b7df4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105067/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>