<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105009/">http://git.reviewboard.kde.org/r/105009/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 23rd, 2012, 7:58 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">patchwise and ui-wise I think this is fine - whats missing is of course a way to upload file templates from within kdevelop (or at least a sane way to create new templates) - without that, I think this addition is not so useful yet, is it?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks.
I have sent a message to kde-files team (I hope this is still the right way to request new categories, I haven't got a response yet). So downloading should be working soon.
Uploading templates is similarly easy, just open a dialog and point to an appropriate directory. But I'm not sure about a way to create new templates. For starters I'll allow loading a directory (instead of an archive) and compressing it. This way they can be created and edited as text files. </pre>
<br />
<p>- Miha</p>
<br />
<p>On May 24th, 2012, 6:37 a.m., Miha Čančula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop, Milian Wolff and Alexander Dymo.</div>
<div>By Miha Čančula.</div>
<p style="color: grey;"><i>Updated May 24, 2012, 6:37 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implement loading templates from local file. Lodaded templates are immediately selected for convenience. Their descriptions are extracted, but their icons are not. I will add icon-extraction after the initial code is reviewed. The archive files are copied to a ~/.kde/share/apps/kdevappwizard/templates/ where the existing code picks them up.
Since I was already adding buttons, I added one for getting new template with KNS as well. It shows a download dialog and refreshes the views, but since no category is defined yet on kde-files.org, it shows all unrelated items.
Note that this code is currently in the "project-templates" branch. I realize it's not ready to be merged just yet (due to missing functionality), but I wanted comments regarding the implementation and user interface.
PS: The source files in appwizard files list a bunch of contributors, who should I add as reviewers?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested locally, archives shipped with KAppTemplate are loaded successfully. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/appwizard/CMakeLists.txt <span style="color: grey">(0e2119197765ad514b8827fda5afe7254f8ea788)</span></li>
<li>plugins/appwizard/kdevappwizard.knsrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/appwizard/projectselectionpage.h <span style="color: grey">(745a1efa1d00c2ac4fe215b7242cf2ed09981e9e)</span></li>
<li>plugins/appwizard/projectselectionpage.cpp <span style="color: grey">(373c66f7e1218858651d38678cc1010b4764308a)</span></li>
<li>plugins/appwizard/projectselectionpage.ui <span style="color: grey">(7a33fdd2c68831776ea5dc8d7259afa831854a41)</span></li>
<li>plugins/appwizard/projecttemplatesmodel.h <span style="color: grey">(cbd91e976e1472dc29d9bc263268bf71d86ec229)</span></li>
<li>plugins/appwizard/projecttemplatesmodel.cpp <span style="color: grey">(1fe09efec92d85c71679648408e8972b1ddd4971)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105009/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105009/s/575/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/05/23/kdev-appwizard-buttons_400x100.png" style="border: 1px black solid;" alt="New buttons in template selection" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>