<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104547/">http://git.reviewboard.kde.org/r/104547/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 0181874c456ab4057f0b740d9f63150cfb1cf6cc by Milian Wolff to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On April 12th, 2012, 8:11 a.m., Ghislain Mary wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Ghislain Mary.</div>
<p style="color: grey;"><i>Updated April 12, 2012, 8:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use KAssistantDialog instead of QWizard for the new class assistant and use the "assistant" word instead of "wizard".
I tried to make as less changes as possible. I put the subtitle of the pages in the title of a groupbox and added an icon for each page.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Created several classes, overriding some classes or not.
Also tried to go back in the assistant to make changes on one of the previous pages.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=181691">181691</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/codegen/createclass.h <span style="color: grey">(47b39f2378db24815f7a79b48bbd6c2a8211cf99)</span></li>
<li>language/codegen/createclass.cpp <span style="color: grey">(e52107f9d198f144d9d27a33a252b574cc6ed979)</span></li>
<li>language/codegen/overridespage.h <span style="color: grey">(7bf3832fdc81543fd90ce7aec6b12bf32da97839)</span></li>
<li>language/codegen/overridespage.cpp <span style="color: grey">(1a64f3de4ba4255c83fae23ef52a80b1071ca9ab)</span></li>
<li>language/codegen/ui/licensechooser.ui <span style="color: grey">(21bea9476d875c9b56d883e569c09c08da1e89b3)</span></li>
<li>language/codegen/ui/newclass.ui <span style="color: grey">(760eef6eed5c24ddbf0a2249450d1bd083c8c490)</span></li>
<li>language/codegen/ui/outputlocation.ui <span style="color: grey">(09110cc01a74c5f938f3df8b3e21e326ffc11280)</span></li>
<li>language/codegen/ui/overridevirtuals.ui <span style="color: grey">(dbf9abe7053dfd9403f6b788bf33192aa553074b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104547/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104547/s/523/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/12/NewClassAssistant_400x100.png" style="border: 1px black solid;" alt="Comparison of QWizard and KAssistantDialog for the new class assistant" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>