<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103955/">http://git.reviewboard.kde.org/r/103955/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The idea is good, but this patch is too inefficient:
1. Calling QualifiedIdentifier.toString() is very expensive, and should only be done for the few items which are actually shown on screen
2. qSort over the whole list is also inefficient, because the list may be huge
Look into the code above your qSort. There, the individual components of a QualifiedIdentifier are accessed efficiently.
Corresponding to your idea, you would have to find a way to put those items which have a match at a deeper match-position 'q' higher up in the quickopen list.
If you implement this, then it will instantly also work for functions, because those have the same data provider.
However, I also see a problem:
When I type the name of a class, then I first want the class itself, and not its constructor.</pre>
<br />
<p>- David</p>
<br />
<p>On April 15th, 2012, 8:44 p.m., Victor Vicente Carvalho wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Victor Vicente Carvalho.</div>
<p style="color: grey;"><i>Updated April 15, 2012, 8:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Improve QuickOpen system to sort items based on a right-to-left approach, putting items that are close to the typed text next to the first matches. This is achieved through a weighted sorter on the ProjectItemDataProvider filter.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran kdevelop over several projects, no problems so far.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/quickopen/projectitemquickopen.cpp <span style="color: grey">(1caadffee64051a0d77d7a65a97ff86b33a78d39)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103955/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>