<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103448/">http://git.reviewboard.kde.org/r/103448/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 10th, 2012, 8:22 a.m., <b>Alexandre Courbot</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still not good unfortunately, the new parseDesignatedInitializer() causes a parse error on constructs like this:
#include <Qt/qstring.h>
void foo(const QString &s);
QString bar();
void f() {
foo( bar() + " " );
QString command;
}
Here the "QString command" line will raise a parser error (parses perfectly without this patch). Slightly changing the above line (like removing the parentheses on bar(), or changing the '+' to a ',' fixes it. Crazy.</pre>
</blockquote>
<p>On April 12th, 2012, 1:02 p.m., <b>Ivan Shapovalov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've somewhat refactored the patch, it passes given testcases and this QString testcase without parse errors.
Could you provide the testcase which makes the original patch enter an infinite loop?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I do not have a testcase, but this happened when loading KDevplatform and KDevelop. After closing from 100% the background parser would eat all your memory. Could you provide the source of your updated version?</pre>
<br />
<p>- Alexandre</p>
<br />
<p>On April 10th, 2012, 6:17 a.m., Alexandre Courbot wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Milian Wolff.</div>
<div>By Alexandre Courbot.</div>
<p style="color: grey;"><i>Updated April 10, 2012, 6:17 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Parser support for C99 designated initializers
Support C99 initializers in the C++ parser, e.g:
struct foo_t foo = {
.has_cake = true,
.nb_candles = 12,
};
int bar[10] = {
[1] = 15,
[9] = 25,
};</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used it for a couple of weeks, ensured the parser tests all pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/parser/parser.h <span style="color: grey">(64b5c505866ac2a0ed847aa67e4c7809df3af6b5)</span></li>
<li>languages/cpp/parser/parser.cpp <span style="color: grey">(a45ee31a1207d56efef292babb2e774b51378ead)</span></li>
<li>languages/cpp/parser/tests/test_parser.h <span style="color: grey">(2869d9ddae2632aced2f2e2fa966382da3a0082d)</span></li>
<li>languages/cpp/parser/tests/test_parser.cpp <span style="color: grey">(94e3ee06dc9187568c000dcdd8baf8d87d1d06e6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103448/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>