<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104486/">http://git.reviewboard.kde.org/r/104486/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated April 5, 2012, 4:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Reworked version of the patch which uses only 0 or 150ms timeout (no interpolation). If there's less than 10k items to be filtered, zero timeout will be used, 150ms otherwise. This changes as you type. When there have ever been more than 10k items in the list, the delay is always used when text is removed (because this requires all items to be scanned again).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I find the recently introduced 150ms-timeout for searching quickopen very annoying, as I loved the instant feedback quickopen had before. It is clear that something like the timer is necessary for large projects, because the items cannot be searched in real-time; however, for smaller projects (and especially for the outline filter!) the additional delay is just plain unnecessary.
This patch adjusts the delay to the amount of items to be searched; it is 0 if the amount of items to be searched is less than 5000, and reaches its maximum of 150ms (the old default value) if there's more than 50.000 items. Those values are just random, and better suggestions are welcome.
An immediately noticeable positive effect of this patch (in every project) is that the outline widget now again always provides instant, smooth feedback.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/quickopen/quickopenmodel.h <span style="color: grey">(3da9f1c)</span></li>
<li>plugins/quickopen/quickopenmodel.cpp <span style="color: grey">(6fd9c89)</span></li>
<li>plugins/quickopen/quickopenplugin.h <span style="color: grey">(75f4fcd)</span></li>
<li>plugins/quickopen/quickopenplugin.cpp <span style="color: grey">(91a9211)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104486/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>