<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104486/">http://git.reviewboard.kde.org/r/104486/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 5th, 2012, 1:58 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104486/diff/3/?file=55654#file55654line509" style="color: black; font-weight: bold; text-decoration: underline;">plugins/quickopen/quickopenplugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void QuickOpenWidget::textChanged( const QString& str )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">508</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_filterTimer</span><span class="p">.</span><span class="n">setInterval</span><span class="p">(</span><span class="n">qMax</span><span class="p">(</span><span class="n">m_model</span><span class="o">-></span><span class="n">getUpdateTimeoutHint</span><span class="p">(),</span> <span class="n">m_filterTimer</span><span class="p">.</span><span class="n">interval</span><span class="p">()));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this should be changed as soon as the number of items in the model changes, so you'll have to connect to some signal</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, but I didn't find that signal... so I thought that place is also fine. :)
Which signal could I connect to?</pre>
<br />
<p>- Sven</p>
<br />
<p>On April 5th, 2012, 12:42 p.m., Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated April 5, 2012, 12:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I find the recently introduced 150ms-timeout for searching quickopen very annoying, as I loved the instant feedback quickopen had before. It is clear that something like the timer is necessary for large projects, because the items cannot be searched in real-time; however, for smaller projects (and especially for the outline filter!) the additional delay is just plain unnecessary.
This patch adjusts the delay to the amount of items to be searched; it is 0 if the amount of items to be searched is less than 5000, and reaches its maximum of 150ms (the old default value) if there's more than 50.000 items. Those values are just random, and better suggestions are welcome.
An immediately noticeable positive effect of this patch (in every project) is that the outline widget now again always provides instant, smooth feedback.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/quickopen/quickopenmodel.h <span style="color: grey">(3da9f1c)</span></li>
<li>plugins/quickopen/quickopenmodel.cpp <span style="color: grey">(6fd9c89)</span></li>
<li>plugins/quickopen/quickopenplugin.cpp <span style="color: grey">(91a9211)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104486/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>