<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104302/">http://git.reviewboard.kde.org/r/104302/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 16th, 2012, 2:48 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104302/diff/1/?file=53451#file53451line98" style="color: black; font-weight: bold; text-decoration: underline;">duchain/declarationbuilder.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void DeclarationBuilder::visitClassDeclaration(ClassDeclarationAst * node)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">87</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="cm">/*if (buildCompleteTypes() && newClass->baseClassesSize() == 0) {</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see above, better port this instead of killing it by commenting it.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't see what is the equivalent of buildCompleteSize(). Also, I'm not sure what it is supposed to do. </pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 16th, 2012, 2:48 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104302/diff/1/?file=53451#file53451line137" style="color: black; font-weight: bold; text-decoration: underline;">duchain/declarationbuilder.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void DeclarationBuilder::classContextOpened(KDevelop::DUContext* context)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">136</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">buildCompleteTypes</span><span class="p">())</span><span class="hl"> </span><span class="p"><span class="hl">{</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">126</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="hl"> </span><span class="c1"><span class="hl">//</span>if (buildCompleteTypes())</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see above</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See above</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 16th, 2012, 2:48 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104302/diff/1/?file=53451#file53451line179" style="color: black; font-weight: bold; text-decoration: underline;">duchain/declarationbuilder.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void DeclarationBuilder::visitImplementsClause(java::ImplementsClauseAst* node)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">177</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">buildCompleteTypes</span><span class="p">())</span><span class="hl"> </span><span class="p"><span class="hl">{</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">168</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="hl"> </span><span class="c1"><span class="hl">//</span>if (buildCompleteTypes())</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see above</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See above</pre>
<br />
<p>- Detlev</p>
<br />
<p>On March 16th, 2012, 12:01 p.m., Detlev Casanova wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Detlev Casanova.</div>
<p style="color: grey;"><i>Updated March 16, 2012, 12:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make kdev-java compile with the new movingranges interface.
Most of the changes are replacing Simple[Range-Cursor] by [Range-Cursor]InRevision</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It does compile (though not with -j5 on my laptop, no idea why)
It doesn't crash but it doesn't work yet either.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(93eebfb)</span></li>
<li>completion/context.h <span style="color: grey">(afefe08)</span></li>
<li>completion/context.cpp <span style="color: grey">(e5b512e)</span></li>
<li>completion/items.cpp <span style="color: grey">(86795d6)</span></li>
<li>completion/model.cpp <span style="color: grey">(3afed23)</span></li>
<li>completion/worker.h <span style="color: grey">(34c6e96)</span></li>
<li>completion/worker.cpp <span style="color: grey">(d26c9fc)</span></li>
<li>duchain/classdeclaration.h <span style="color: grey">(4f6faf5)</span></li>
<li>duchain/classdeclaration.cpp <span style="color: grey">(28bfc34)</span></li>
<li>duchain/contextbuilder.h <span style="color: grey">(6f799c5)</span></li>
<li>duchain/contextbuilder.cpp <span style="color: grey">(0d26d43)</span></li>
<li>duchain/declarationbuilder.h <span style="color: grey">(28fcd74)</span></li>
<li>duchain/declarationbuilder.cpp <span style="color: grey">(ed263a9)</span></li>
<li>duchain/ducontext.h <span style="color: grey">(3ea0010)</span></li>
<li>duchain/ducontext.cpp <span style="color: grey">(0224199)</span></li>
<li>duchain/dumpchain.cpp <span style="color: grey">(f0cf9e4)</span></li>
<li>duchain/editorintegrator.h <span style="color: grey">(b2bfd5a)</span></li>
<li>duchain/editorintegrator.cpp <span style="color: grey">(161f9ea)</span></li>
<li>duchain/expressionvisitor.cpp <span style="color: grey">(a3e0207)</span></li>
<li>duchain/identifiercompiler.cpp <span style="color: grey">(aaad037)</span></li>
<li>duchain/overloadresolver.cpp <span style="color: grey">(26b88fd)</span></li>
<li>duchain/topducontext.h <span style="color: grey">(d093186)</span></li>
<li>duchain/topducontext.cpp <span style="color: grey">(df88aed)</span></li>
<li>duchain/typebuilder.h <span style="color: grey">(ea3817d)</span></li>
<li>duchain/typebuilder.cpp <span style="color: grey">(246cf3b)</span></li>
<li>duchain/typeutils.cpp <span style="color: grey">(42c4eb5)</span></li>
<li>duchain/usebuilder.h <span style="color: grey">(3d141b4)</span></li>
<li>duchain/usebuilder.cpp <span style="color: grey">(244eb95)</span></li>
<li>javalanguagesupport.h <span style="color: grey">(b94790e)</span></li>
<li>javalanguagesupport.cpp <span style="color: grey">(49c949b)</span></li>
<li>kdevjavasupport.desktop <span style="color: grey">(b9f226a)</span></li>
<li>parsejob.cpp <span style="color: grey">(7c72d61)</span></li>
<li>parser/CMakeLists.txt <span style="color: grey">(cc35848)</span></li>
<li>parser/java.g <span style="color: grey">(f5b1978)</span></li>
<li>parser/parsesession.h <span style="color: grey">(cbb7cba)</span></li>
<li>parser/parsesession.cpp <span style="color: grey">(aa466b2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104302/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>