<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104127/">http://git.reviewboard.kde.org/r/104127/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This code has been sitting in our codebase for quite longtime and even though it's well tested, we already knew that there were issues (roberto said that in many occasions). I'm interested in knowing what David thinks about such a patch, but it made sense to me and I think we can really use some improvements in this area.
I'm fine with having this code in master to have it properly tested.</pre>
<br />
<p>- Aleix</p>
<br />
<p>On March 1st, 2012, 2:41 a.m., Milian Wolff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and David Nolden.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated March 1, 2012, 2:41 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On 64bit sizeof(PrimaryExpressionAST) == 64, but with this patch it reduces to 40 by using a union + enum.
The code-handling is a bit changed, but well... is this OK to land in master?
This is another step towards a reduced memory consumption for the test file in https://bugs.kde.org/show_bug.cgi?id=291248 with this patch the consumption goes down by ~200mb for the given test file</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">all unit tests pass</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/cppduchain/expressionvisitor.cpp <span style="color: grey">(0ef76a6)</span></li>
<li>languages/cpp/parser/ast.h <span style="color: grey">(46ecac7)</span></li>
<li>languages/cpp/parser/codegenerator.cpp <span style="color: grey">(962fe5b)</span></li>
<li>languages/cpp/parser/default_visitor.cpp <span style="color: grey">(174e5d9)</span></li>
<li>languages/cpp/parser/parser.cpp <span style="color: grey">(50c09a8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104127/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>