<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103619/">http://git.reviewboard.kde.org/r/103619/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 8th, 2012, 3:39 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ah well, just the default dtor won't make it abi-stable as we'd have to change the inheritance probably, or?
anyhow, I don't see a reason to make the saver public api to begin with. Could you move it to plugins/projectmanagerview ? or why should it be public in your opinion?
thanks</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The change to a default ctor was alluding to the fact that in order to use a class as template argument for KViewStateMaintainer it must have a default constructor. I'm not sure why the inheritance would ever possibly change...?
I agree with you that it is unlikely anyone would have use for ProjectModelSaver exported. I've moved it to plugins/projectmanagerview.</pre>
<br />
<p>- Andrew</p>
<br />
<p>On January 8th, 2012, 6:59 p.m., Andrew Fuller wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Andrew Fuller.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2012, 6:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Save/Restore the ProjectTreeView. This enables a more seamless transition when returning to a project that was closed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Load a session, Exit, and return. Voilà! The tree is right where you left it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/projectmanagerview/CMakeLists.txt <span style="color: grey">(7b58e8e5489819b0370f5d55e0218f063da90af2)</span></li>
<li>plugins/projectmanagerview/projectmodelsaver.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/projectmanagerview/projectmodelsaver.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/projectmanagerview/projecttreeview.h <span style="color: grey">(16893f0713b83a78a5b025a55fcfa082265d4419)</span></li>
<li>plugins/projectmanagerview/projecttreeview.cpp <span style="color: grey">(8237af513627c0459d571de2bccc275e8a4b0ae9)</span></li>
<li>shell/sessioncontroller.h <span style="color: grey">(551894d4131218b9ab2640e28f2c354ce319a105)</span></li>
<li>shell/sessioncontroller.cpp <span style="color: grey">(d2ee8732710e0e4bded56e547d83a3906b20b018)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103619/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>