<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103549/">http://git.reviewboard.kde.org/r/103549/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Filip Brcic.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I recently worked on a C++ project that was using a darcs repository (Darcs is a distributed VCS, for more info visit darcs.net). Unfortunately for me, unlike git or mercurial, darcs is using a _darcs directory to hold all repo data, and kdevelop is filtering only hidden files (ie. those starting with a dot), so the Quick open was rendered useless as it listed tons of _darcs/something files that I certainly didn't want to edit by hand.
That's why I patched kdevelop to filter out _darcs directories. I simply added additional if in the cmakemanager.cpp file into the filterFiles function (it filtered only backup files).
I realize this cannot be a top priority to merge, but since it is an extremely minor fix, I hope you'll integrate it into kdevelop anyways.
Best regards,
Filip</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've compiled kdevelop with this patch on Gentoo (4.2.2 is currently stable Gentoo version, but the patch is from git tip) and now it successfully filters out _darcs directories rendering quickopen usable again.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectmanagers/cmake/cmakemanager.cpp <span style="color: grey">(7fd75da)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103549/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>