<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103386/">http://git.reviewboard.kde.org/r/103386/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 23rd, 2011, 8:17 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Uhm sorry, but when I download the diff it is still not in the "format-patch" format. Just look at the downloaded file, it directly starts with the patch and gives no information about you, nor any commit message or such.
please try again</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still seems not to work. Don't know why.
So i'll provide the file here:
http://branleb.de/kdevelop-patches/0001-Applied-KDevPlatform-changes-for-ISourceFormatter-to.patch</pre>
<br />
<p>- Florian</p>
<br />
<p>On December 15th, 2011, 1:07 a.m., Florian Zumkeller-Quast wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Quanta.</div>
<div>By Florian Zumkeller-Quast.</div>
<p style="color: grey;"><i>Updated Dec. 15, 2011, 1:07 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since the last changes of ISourceFormatter from KDevPlatform Quanta was broken and did not compile.
This patch fixes the compiling issues by changing phpformatterplugin and xmlformatterplugin to the new interface of ISourceFormatter.
During the testing it looked to me that there are two different options storing the indentation value for a formatter:
"INDENT" and "indent_size". Because only the latter contained a non-zero value, i changed the behaviour to use the latter one.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/xml/formatter/formatterplugin.h <span style="color: grey">(dbe183a)</span></li>
<li>languages/xml/formatter/formatterplugin.cpp <span style="color: grey">(4e62a1e)</span></li>
<li>plugins/phpformatter/formatterplugin.h <span style="color: grey">(6dc7028)</span></li>
<li>plugins/phpformatter/formatterplugin.cpp <span style="color: grey">(f1ca6fd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103386/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>