<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103501/">http://git.reviewboard.kde.org/r/103501/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 78040e42b19ee4546e3a64ced789feb318c3ee06 by Lambert CLARA to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On December 22nd, 2011, 8:16 a.m., Lambert CLARA wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Aleix Pol Gonzalez.</div>
<div>By Lambert CLARA.</div>
<p style="color: grey;"><i>Updated Dec. 22, 2011, 8:16 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When kdevelop is closed having a splitted view, the next reopening creates a "gray" widget in the middle of the mainwindow. Closing the tabs afterwards may lead to a crash.
The method cleanCentralWidget was iterating through the mainwindow splitter's content with a 'for' loop to delete the widgets inside, but this cannot work because each "delete" of a widget changes the count().
A simple 'while' loop instead fixes it.
I don't think there is an opened bug for this, shoud I open one ?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Split views, change areas from debug/code, close and reopen kdevelop and check if all is reloaded correctly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sublime/mainwindow_p.cpp <span style="color: grey">(61f4804)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103501/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>