Can you please upload the patch to <a href="http://reviewboard.kde.org">http://reviewboard.kde.org</a>?<div><br></div><div>This will make it easier to review and discuss :).</div><div><br></div><div>Thanks!</div><div>Aleix<br>
<br><div class="gmail_quote">2011/12/20 François-Marie de Jouvencel <span dir="ltr"><<a href="mailto:fm.de.jouvencel@gmail.com">fm.de.jouvencel@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Oops I'm sorry, forgot to clean up some debug code I had put in, here is a better version.<div class="HOEnZb"><div class="h5"><br><br><div class="gmail_quote">2011/12/20 François-Marie de Jouvencel <span dir="ltr"><<a href="mailto:fm.de.jouvencel@gmail.com" target="_blank">fm.de.jouvencel@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>Hello everyone, and thanks for the great work!</div><div><br></div><div>I was missing support for C++11 custom string literals : that is, strings like "hello"_world are valid in C++11 (provided you define : some_type operator"" _world(const char * str, size_t num_chars) , but I'm sure you know this already). So I struggled with the code and finally came up with a small patch (a few lines, really, in lexer.cpp) to do the trick. So far I haven't noticed any negative side effects (besides, of course, not detecting errors in C++03 when custom literals are used, but I don't think its a huge problem), so I guess I didnt break anything and I submit it to you.</div>
<div><br></div>The patch was created using the command : git diff --no-prefix > add_custom_string_literals.patch , please tell me if that's not the right way to proceed.<div><br></div><div>Best regards,</div><div>
<br></div><div>FM</div>
</blockquote></div><br>
</div></div><br>--<br>
KDevelop-devel mailing list<br>
<a href="mailto:KDevelop-devel@kdevelop.org">KDevelop-devel@kdevelop.org</a><br>
<a href="https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel" target="_blank">https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel</a><br>
<br></blockquote></div><br></div>