<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103397/">http://git.reviewboard.kde.org/r/103397/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 1a0aeb55ff099d31fd6fe4f7e02c70f8c5f122ea by Friedrich W. H. Kossebau to branch 4.2.</pre>
<br />
<p>- Commit</p>
<br />
<p>On December 12th, 2011, 8:10 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Dec. 12, 2011, 8:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The Kasten/Okteta libs of the upcoming Okteta v0.8 have a versioned namespace, the Okteta plugin will not be compiled with those libs ATM.
Attached patch changes that, and will compile with whatever version there is.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works for me, both with the old libs/headers installed and/or with the new libs/headers installed or none at all.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindLibKasten.cmake <span style="color: grey">(573782b)</span></li>
<li>cmake/modules/FindLibOkteta.cmake <span style="color: grey">(6371c11)</span></li>
<li>cmake/modules/FindLibOktetaKasten.cmake <span style="color: grey">(f641fe1)</span></li>
<li>utils/CMakeLists.txt <span style="color: grey">(822683d)</span></li>
<li>utils/okteta/CMakeLists.txt <span style="color: grey">(66bf8b5)</span></li>
<li>utils/okteta/kastentoolviewwidget.h <span style="color: grey">(3a5fd7e)</span></li>
<li>utils/okteta/kastentoolviewwidget.cpp <span style="color: grey">(c69a395)</span></li>
<li>utils/okteta/oktetadocument.h <span style="color: grey">(aba0996)</span></li>
<li>utils/okteta/oktetadocument.cpp <span style="color: grey">(cbe41e8)</span></li>
<li>utils/okteta/oktetatoolviewfactory.h <span style="color: grey">(ddc7770)</span></li>
<li>utils/okteta/oktetatoolviewfactory.cpp <span style="color: grey">(a483f5c)</span></li>
<li>utils/okteta/oktetaview.h <span style="color: grey">(9dad1ea)</span></li>
<li>utils/okteta/oktetawidget.h <span style="color: grey">(dac83cf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103397/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>