<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103386/">http://git.reviewboard.kde.org/r/103386/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Quanta.</div>
<div>By Florian Zumkeller-Quast.</div>
<p style="color: grey;"><i>Updated Dec. 15, 2011, 1:07 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch created by git format-patch as requested</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since the last changes of ISourceFormatter from KDevPlatform Quanta was broken and did not compile.
This patch fixes the compiling issues by changing phpformatterplugin and xmlformatterplugin to the new interface of ISourceFormatter.
During the testing it looked to me that there are two different options storing the indentation value for a formatter:
"INDENT" and "indent_size". Because only the latter contained a non-zero value, i changed the behaviour to use the latter one.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/xml/formatter/formatterplugin.h <span style="color: grey">(dbe183a)</span></li>
<li>languages/xml/formatter/formatterplugin.cpp <span style="color: grey">(4e62a1e)</span></li>
<li>plugins/phpformatter/formatterplugin.h <span style="color: grey">(6dc7028)</span></li>
<li>plugins/phpformatter/formatterplugin.cpp <span style="color: grey">(f1ca6fd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103386/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>